Re: On patch series version tags, and also cover letters (was: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG)

2022-03-29 Thread Peter Maydell
On Tue, 29 Mar 2022 at 10:55, Kshitij Suri wrote: > On 29/03/22 3:18 pm, Peter Maydell wrote: > > Note that a multi-patch series always needs a cover letter, > > even if its contents are quite brief. Some of the automatic > > tooling gets confused by multi-patch series with no cover letter. > > Co

Re: On patch series version tags, and also cover letters (was: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG)

2022-03-29 Thread Kshitij Suri
On 29/03/22 3:18 pm, Peter Maydell wrote: On Tue, 29 Mar 2022 at 09:03, Markus Armbruster wrote: A cover letter (git format-patch --cover-letter) lets you write an introduction to the whole series. Simple series may not need an introduction, but complex ones do. I always use one except when

Re: On patch series version tags, and also cover letters (was: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG)

2022-03-29 Thread Peter Maydell
On Tue, 29 Mar 2022 at 09:03, Markus Armbruster wrote: > A cover letter (git format-patch --cover-letter) lets you write an > introduction to the whole series. Simple series may not need an > introduction, but complex ones do. I always use one except when the > "series" is a single patch. Note

Re: On patch series version tags, and also cover letters (was: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG)

2022-03-29 Thread Kshitij Suri
On 29/03/22 2:31 pm, Daniel P. Berrangé wrote: On Tue, Mar 29, 2022 at 09:59:55AM +0200, Markus Armbruster wrote: Kshitij Suri writes: On 29/03/22 12:12 pm, Markus Armbruster wrote: If I count correctly, this is the fifth posting tagged "v2". Don't do that, please, as it's quite confusing

Re: On patch series version tags, and also cover letters (was: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG)

2022-03-29 Thread Daniel P . Berrangé
On Tue, Mar 29, 2022 at 09:59:55AM +0200, Markus Armbruster wrote: > Kshitij Suri writes: > > > On 29/03/22 12:12 pm, Markus Armbruster wrote: > >> If I count correctly, this is the fifth posting tagged "v2". Don't do > >> that, please, as it's quite confusing. > >> > > Thank you for your review

Re: On patch series version tags, and also cover letters (was: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG)

2022-03-29 Thread Kshitij Suri
On 29/03/22 1:29 pm, Markus Armbruster wrote: Kshitij Suri writes: On 29/03/22 12:12 pm, Markus Armbruster wrote: If I count correctly, this is the fifth posting tagged "v2". Don't do that, please, as it's quite confusing. Thank you for your review and I apologise for that since I am fai

On patch series version tags, and also cover letters (was: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG)

2022-03-29 Thread Markus Armbruster
Kshitij Suri writes: > On 29/03/22 12:12 pm, Markus Armbruster wrote: >> If I count correctly, this is the fifth posting tagged "v2". Don't do >> that, please, as it's quite confusing. >> > Thank you for your review and I apologise for that since I am fairly > new to upstreaming. As per what I r

Re: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG

2022-03-29 Thread Kshitij Suri
On 29/03/22 12:12 pm, Markus Armbruster wrote: If I count correctly, this is the fifth posting tagged "v2". Don't do that, please, as it's quite confusing. Thank you for your review and I apologise for that since I am fairly new to upstreaming. As per what I read version updates should be do

Re: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG

2022-03-28 Thread Markus Armbruster
If I count correctly, this is the fifth posting tagged "v2". Don't do that, please, as it's quite confusing.

[PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG

2022-03-28 Thread Kshitij Suri
Currently screendump only supports PPM format, which is un-compressed and not standard. Added a "format" parameter to qemu monitor screendump capabilites to support PNG image capture using libpng. The param was added in QAPI schema of screendump present in ui.json along with png_save() function whi

Re: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG

2022-03-28 Thread Kshitij Suri
On 28/03/22 3:22 pm, Daniel P. Berrangé wrote: On Tue, Mar 22, 2022 at 10:49:53AM +, Kshitij Suri wrote: Currently screendump only supports PPM format, which is un-compressed and not standard. Added a "format" parameter to qemu monitor screendump capabilites to support PNG image capture us

Re: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG

2022-03-28 Thread Daniel P . Berrangé
On Tue, Mar 22, 2022 at 10:49:53AM +, Kshitij Suri wrote: > Currently screendump only supports PPM format, which is un-compressed and not > standard. Added a "format" parameter to qemu monitor screendump capabilites > to support PNG image capture using libpng. The param was added in QAPI schema

Re: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG

2022-03-28 Thread Kshitij Suri
Hi, Hope this mail finds you well. I have updated the code as required and would be grateful if you could review and suggest changes that are needed to be implemented. In case no change is required, please do let me know the next steps for the same. Regards, Kshitij Suri On 22/03/22 4:19 pm,

[PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG

2022-03-22 Thread Kshitij Suri
Currently screendump only supports PPM format, which is un-compressed and not standard. Added a "format" parameter to qemu monitor screendump capabilites to support PNG image capture using libpng. The param was added in QAPI schema of screendump present in ui.json along with png_save() function whi

Re: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG

2022-03-22 Thread Kshitij Suri
On 22/03/22 3:45 pm, Markus Armbruster wrote: Daniel P. Berrangé writes: On Tue, Mar 22, 2022 at 08:18:45AM +, Kshitij Suri wrote: Currently screendump only supports PPM format, which is un-compressed and not standard. Added a "format" parameter to qemu monitor screendump capabilites to

Re: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG

2022-03-22 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Mar 22, 2022 at 08:18:45AM +, Kshitij Suri wrote: >> Currently screendump only supports PPM format, which is un-compressed and not >> standard. Added a "format" parameter to qemu monitor screendump capabilites >> to support PNG image capture using libpng.

Re: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG

2022-03-22 Thread Kshitij Suri
On 22/03/22 3:17 pm, Daniel P. Berrangé wrote: On Tue, Mar 22, 2022 at 08:18:45AM +, Kshitij Suri wrote: Currently screendump only supports PPM format, which is un-compressed and not standard. Added a "format" parameter to qemu monitor screendump capabilites to support PNG image capture us

Re: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG

2022-03-22 Thread Daniel P . Berrangé
On Tue, Mar 22, 2022 at 08:18:45AM +, Kshitij Suri wrote: > Currently screendump only supports PPM format, which is un-compressed and not > standard. Added a "format" parameter to qemu monitor screendump capabilites > to support PNG image capture using libpng. The param was added in QAPI schema

[PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG

2022-03-22 Thread Kshitij Suri
Currently screendump only supports PPM format, which is un-compressed and not standard. Added a "format" parameter to qemu monitor screendump capabilites to support PNG image capture using libpng. The param was added in QAPI schema of screendump present in ui.json along with png_save() function whi

Re: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG.

2022-03-16 Thread Kshitij Suri
On 15/03/22 3:49 pm, Daniel P. Berrangé wrote: On Tue, Mar 15, 2022 at 11:06:31AM +0100, Markus Armbruster wrote: Kshitij Suri writes: On 11/03/22 5:50 pm, Markus Armbruster wrote: Kshitij Suri writes: Currently screendump only supports PPM format, which is un-compressed and not standar

Re: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG.

2022-03-15 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Mar 15, 2022 at 11:06:31AM +0100, Markus Armbruster wrote: >> Kshitij Suri writes: >> >> > On 11/03/22 5:50 pm, Markus Armbruster wrote: >> >> Kshitij Suri writes: >> >> >> >>> Currently screendump only supports PPM format, which is un-compressed >> >>> an

Re: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG.

2022-03-15 Thread Daniel P . Berrangé
On Tue, Mar 15, 2022 at 11:06:31AM +0100, Markus Armbruster wrote: > Kshitij Suri writes: > > > On 11/03/22 5:50 pm, Markus Armbruster wrote: > >> Kshitij Suri writes: > >> > >>> Currently screendump only supports PPM format, which is un-compressed and > >>> not > >>> standard. Added a "format"

Re: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG.

2022-03-15 Thread Markus Armbruster
Kshitij Suri writes: > On 11/03/22 5:50 pm, Markus Armbruster wrote: >> Kshitij Suri writes: >> >>> Currently screendump only supports PPM format, which is un-compressed and >>> not >>> standard. Added a "format" parameter to qemu monitor screendump capabilites >>> to support PNG image capture

Re: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG.

2022-03-14 Thread Kshitij Suri
On 11/03/22 5:50 pm, Markus Armbruster wrote: Kshitij Suri writes: Currently screendump only supports PPM format, which is un-compressed and not standard. Added a "format" parameter to qemu monitor screendump capabilites to support PNG image capture using libpng. The param was added in QAPI

Re: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG.

2022-03-11 Thread Markus Armbruster
Kshitij Suri writes: > Currently screendump only supports PPM format, which is un-compressed and not > standard. Added a "format" parameter to qemu monitor screendump capabilites > to support PNG image capture using libpng. The param was added in QAPI schema > of screendump present in ui.json alo

Re: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG.

2022-03-07 Thread Kshitij Suri
Hi, Hope this mail finds you well. I have updated the code as required and request you to review and suggest changes that are needed to be implemented. In case no change is required, please do let me know the next steps for the same. Regards, Kshitij Suri On 01/03/22 12:14 pm, Kshitij Suri

[PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG.

2022-02-28 Thread Kshitij Suri
Currently screendump only supports PPM format, which is un-compressed and not standard. Added a "format" parameter to qemu monitor screendump capabilites to support PNG image capture using libpng. The param was added in QAPI schema of screendump present in ui.json along with png_save() function whi

[PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG.

2022-02-27 Thread Kshitij Suri
Currently screendump only supports PPM format, which is un-compressed and not standard. Added a "format" parameter to qemu monitor screendump capabilites to support PNG image capture using libpng. The param was added in QAPI schema of screendump present in ui.json along with png_save() function whi