Re: [PATCH v2 19/53] migration/rdma: Replace dangerous macro CHECK_ERROR_STATE()

2023-10-04 Thread Juan Quintela
Markus Armbruster wrote: > Hiding return statements in macros is a bad idea. Use a function > instead, and open code the return part. > > Signed-off-by: Markus Armbruster > Reviewed-by: Fabiano Rosas > Reviewed-by: Li Zhijian Reviewed-by: Juan Quintela I hated this macro, thanks.

[PATCH v2 19/53] migration/rdma: Replace dangerous macro CHECK_ERROR_STATE()

2023-09-28 Thread Markus Armbruster
Hiding return statements in macros is a bad idea. Use a function instead, and open code the return part. Signed-off-by: Markus Armbruster Reviewed-by: Fabiano Rosas Reviewed-by: Li Zhijian --- migration/rdma.c | 43 +++ 1 file changed, 27 insertions(+),