Re: [PATCH v2 19/22] tests/qtest/migration: Add migration-test-smoke

2024-12-20 Thread Fabiano Rosas
Peter Xu writes: > On Thu, Dec 19, 2024 at 04:31:04PM -0300, Fabiano Rosas wrote: >> We shouldn't change stuff that's also used by the rest of the >> community. People know about QEMU_TEST_FLAKY_TESTS and -m slow. These >> must continue to work the same. > > I see what I overlook; it's used much

Re: [PATCH v2 19/22] tests/qtest/migration: Add migration-test-smoke

2024-12-20 Thread Peter Xu
On Fri, Dec 20, 2024 at 03:34:32PM +, Daniel P. Berrangé wrote: > On Fri, Dec 20, 2024 at 10:18:37AM -0500, Peter Xu wrote: > > On Thu, Dec 19, 2024 at 04:31:04PM -0300, Fabiano Rosas wrote: > > > We shouldn't change stuff that's also used by the rest of the > > > community. People know about Q

Re: [PATCH v2 19/22] tests/qtest/migration: Add migration-test-smoke

2024-12-20 Thread Daniel P . Berrangé
On Fri, Dec 20, 2024 at 10:18:37AM -0500, Peter Xu wrote: > On Thu, Dec 19, 2024 at 04:31:04PM -0300, Fabiano Rosas wrote: > > We shouldn't change stuff that's also used by the rest of the > > community. People know about QEMU_TEST_FLAKY_TESTS and -m slow. These > > must continue to work the same.

Re: [PATCH v2 19/22] tests/qtest/migration: Add migration-test-smoke

2024-12-20 Thread Peter Xu
On Thu, Dec 19, 2024 at 04:31:04PM -0300, Fabiano Rosas wrote: > We shouldn't change stuff that's also used by the rest of the > community. People know about QEMU_TEST_FLAKY_TESTS and -m slow. These > must continue to work the same. I see what I overlook; it's used much more than I thought in qtes

Re: [PATCH v2 19/22] tests/qtest/migration: Add migration-test-smoke

2024-12-19 Thread Fabiano Rosas
Peter Xu writes: > On Thu, Dec 19, 2024 at 12:38:05PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Wed, Dec 18, 2024 at 06:08:01PM -0300, Fabiano Rosas wrote: >> >> Peter Xu writes: >> >> >> >> > On Wed, Dec 18, 2024 at 03:13:08PM -0300, Fabiano Rosas wrote: >> >> >> Peter Xu w

Re: [PATCH v2 19/22] tests/qtest/migration: Add migration-test-smoke

2024-12-19 Thread Peter Xu
On Thu, Dec 19, 2024 at 12:38:05PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Wed, Dec 18, 2024 at 06:08:01PM -0300, Fabiano Rosas wrote: > >> Peter Xu writes: > >> > >> > On Wed, Dec 18, 2024 at 03:13:08PM -0300, Fabiano Rosas wrote: > >> >> Peter Xu writes: > >> >> > >> >> > On

Re: [PATCH v2 19/22] tests/qtest/migration: Add migration-test-smoke

2024-12-19 Thread Fabiano Rosas
Peter Xu writes: > On Wed, Dec 18, 2024 at 06:08:01PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Wed, Dec 18, 2024 at 03:13:08PM -0300, Fabiano Rosas wrote: >> >> Peter Xu writes: >> >> >> >> > On Wed, Nov 13, 2024 at 04:46:27PM -0300, Fabiano Rosas wrote: >> >> >> diff --git

Re: [PATCH v2 19/22] tests/qtest/migration: Add migration-test-smoke

2024-12-18 Thread Peter Xu
On Wed, Dec 18, 2024 at 06:08:01PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Wed, Dec 18, 2024 at 03:13:08PM -0300, Fabiano Rosas wrote: > >> Peter Xu writes: > >> > >> > On Wed, Nov 13, 2024 at 04:46:27PM -0300, Fabiano Rosas wrote: > >> >> diff --git a/tests/qtest/migration-test

Re: [PATCH v2 19/22] tests/qtest/migration: Add migration-test-smoke

2024-12-18 Thread Fabiano Rosas
Peter Xu writes: > On Wed, Dec 18, 2024 at 03:13:08PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Wed, Nov 13, 2024 at 04:46:27PM -0300, Fabiano Rosas wrote: >> >> diff --git a/tests/qtest/migration-test-smoke.c >> >> b/tests/qtest/migration-test-smoke.c >> >> new file mode 1006

Re: [PATCH v2 19/22] tests/qtest/migration: Add migration-test-smoke

2024-12-18 Thread Peter Xu
On Wed, Dec 18, 2024 at 03:13:08PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Wed, Nov 13, 2024 at 04:46:27PM -0300, Fabiano Rosas wrote: > >> diff --git a/tests/qtest/migration-test-smoke.c > >> b/tests/qtest/migration-test-smoke.c > >> new file mode 100644 > >> index 00..f

Re: [PATCH v2 19/22] tests/qtest/migration: Add migration-test-smoke

2024-12-18 Thread Fabiano Rosas
Peter Xu writes: > On Wed, Nov 13, 2024 at 04:46:27PM -0300, Fabiano Rosas wrote: >> diff --git a/tests/qtest/migration-test-smoke.c >> b/tests/qtest/migration-test-smoke.c >> new file mode 100644 >> index 00..ff2d72881f >> --- /dev/null >> +++ b/tests/qtest/migration-test-smoke.c >> @@

Re: [PATCH v2 19/22] tests/qtest/migration: Add migration-test-smoke

2024-12-18 Thread Peter Xu
On Wed, Nov 13, 2024 at 04:46:27PM -0300, Fabiano Rosas wrote: > diff --git a/tests/qtest/migration-test-smoke.c > b/tests/qtest/migration-test-smoke.c > new file mode 100644 > index 00..ff2d72881f > --- /dev/null > +++ b/tests/qtest/migration-test-smoke.c > @@ -0,0 +1,39 @@ > +/* SPDX-Lic

[PATCH v2 19/22] tests/qtest/migration: Add migration-test-smoke

2024-11-13 Thread Fabiano Rosas
Add a new migration test to be ran as smoke test for each QEMU target. This test will run only when the QEMU binary being used has no KVM support, i.e. smoke tests run only on TCG. Also modify the existing migration-test to run only when KVM is present, i.e. the full set of tests will only run on