Re: [PATCH v2 18/25] hw/sd: ssi-sd: Bump up version ids of VMStateDescription

2021-01-25 Thread Bin Meng
On Mon, Jan 25, 2021 at 6:41 PM Dr. David Alan Gilbert wrote: > > * Bin Meng (bmeng...@gmail.com) wrote: > > On Mon, Jan 25, 2021 at 12:59 AM Philippe Mathieu-Daudé > > wrote: > > > > > > On 1/23/21 11:40 AM, Bin Meng wrote: > > > > From: Bin Meng > > > > > > > > With all these fixes and improv

Re: [PATCH v2 18/25] hw/sd: ssi-sd: Bump up version ids of VMStateDescription

2021-01-25 Thread Dr. David Alan Gilbert
* Bin Meng (bmeng...@gmail.com) wrote: > On Mon, Jan 25, 2021 at 12:59 AM Philippe Mathieu-Daudé > wrote: > > > > On 1/23/21 11:40 AM, Bin Meng wrote: > > > From: Bin Meng > > > > > > With all these fixes and improvements, there is no way for the > > > VMStateDescription to keep backward compati

Re: [PATCH v2 18/25] hw/sd: ssi-sd: Bump up version ids of VMStateDescription

2021-01-24 Thread Bin Meng
On Mon, Jan 25, 2021 at 12:59 AM Philippe Mathieu-Daudé wrote: > > On 1/23/21 11:40 AM, Bin Meng wrote: > > From: Bin Meng > > > > With all these fixes and improvements, there is no way for the > > VMStateDescription to keep backward compatibility. We will have > > to bump up version ids. > > Unf

Re: [PATCH v2 18/25] hw/sd: ssi-sd: Bump up version ids of VMStateDescription

2021-01-24 Thread Philippe Mathieu-Daudé
On 1/24/21 5:59 PM, Philippe Mathieu-Daudé wrote: > On 1/23/21 11:40 AM, Bin Meng wrote: >> From: Bin Meng >> >> With all these fixes and improvements, there is no way for the >> VMStateDescription to keep backward compatibility. We will have >> to bump up version ids. > > Unfortunately this brea

Re: [PATCH v2 18/25] hw/sd: ssi-sd: Bump up version ids of VMStateDescription

2021-01-24 Thread Philippe Mathieu-Daudé
On 1/23/21 11:40 AM, Bin Meng wrote: > From: Bin Meng > > With all these fixes and improvements, there is no way for the > VMStateDescription to keep backward compatibility. We will have > to bump up version ids. Unfortunately this breaks bisectability (think about downstream distributions cherr

[PATCH v2 18/25] hw/sd: ssi-sd: Bump up version ids of VMStateDescription

2021-01-23 Thread Bin Meng
From: Bin Meng With all these fixes and improvements, there is no way for the VMStateDescription to keep backward compatibility. We will have to bump up version ids. The s->mode check in the post_load() hook is also updated. Signed-off-by: Bin Meng --- Changes in v2: - new patch: bump up ver