Re: [PATCH v2 16/16] sd/milkymist-memcard: Fix error API violation

2020-06-22 Thread Philippe Mathieu-Daudé
On 6/22/20 11:42 AM, Markus Armbruster wrote: > The Error ** argument must be NULL, &error_abort, &error_fatal, or a > pointer to a variable containing NULL. Passing an argument of the > latter kind twice without clearing it in between is wrong: if the > first call sets an error, it no longer poin

[PATCH v2 16/16] sd/milkymist-memcard: Fix error API violation

2020-06-22 Thread Markus Armbruster
The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. milkymist_memcard_rea