Re: [PATCH v2 15/29] migration/ram: Add support for 'fixed-ram' outgoing migration

2023-11-01 Thread Peter Xu
On Wed, Nov 01, 2023 at 04:37:12PM +, Daniel P. Berrangé wrote: > It doesn't contain thread number information directly, but it can > be implicit from the data layout. > > If you want parallel I/O, each thread has to know it is the only > one reading/writing to a particular region of the file.

Re: [PATCH v2 15/29] migration/ram: Add support for 'fixed-ram' outgoing migration

2023-11-01 Thread Daniel P . Berrangé
On Wed, Nov 01, 2023 at 12:24:22PM -0400, Peter Xu wrote: > On Wed, Nov 01, 2023 at 03:52:18PM +, Daniel P. Berrangé wrote: > > On Wed, Nov 01, 2023 at 11:23:37AM -0400, Peter Xu wrote: > > > On Wed, Oct 25, 2023 at 10:39:58AM +0100, Daniel P. Berrangé wrote: > > > > If I'm reading the code cor

Re: [PATCH v2 15/29] migration/ram: Add support for 'fixed-ram' outgoing migration

2023-11-01 Thread Peter Xu
On Wed, Nov 01, 2023 at 03:52:18PM +, Daniel P. Berrangé wrote: > On Wed, Nov 01, 2023 at 11:23:37AM -0400, Peter Xu wrote: > > On Wed, Oct 25, 2023 at 10:39:58AM +0100, Daniel P. Berrangé wrote: > > > If I'm reading the code correctly the new format has some padding > > > such that each "rambl

Re: [PATCH v2 15/29] migration/ram: Add support for 'fixed-ram' outgoing migration

2023-11-01 Thread Daniel P . Berrangé
On Wed, Nov 01, 2023 at 11:23:37AM -0400, Peter Xu wrote: > On Wed, Oct 25, 2023 at 10:39:58AM +0100, Daniel P. Berrangé wrote: > > If I'm reading the code correctly the new format has some padding > > such that each "ramblock pages" region starts on a 1 MB boundary. > > > > eg so we get: > > > >

Re: [PATCH v2 15/29] migration/ram: Add support for 'fixed-ram' outgoing migration

2023-11-01 Thread Peter Xu
On Wed, Oct 25, 2023 at 10:39:58AM +0100, Daniel P. Berrangé wrote: > If I'm reading the code correctly the new format has some padding > such that each "ramblock pages" region starts on a 1 MB boundary. > > eg so we get: > > > | ramblock 1 header| >

Re: [PATCH v2 15/29] migration/ram: Add support for 'fixed-ram' outgoing migration

2023-10-31 Thread Peter Xu
On Tue, Oct 31, 2023 at 02:33:04PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Mon, Oct 23, 2023 at 05:35:54PM -0300, Fabiano Rosas wrote: > >> From: Nikolay Borisov > >> > >> Implement the outgoing migration side for the 'fixed-ram' capability. > >> > >> A bitmap is introduced to

Re: [PATCH v2 15/29] migration/ram: Add support for 'fixed-ram' outgoing migration

2023-10-31 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Oct 23, 2023 at 05:35:54PM -0300, Fabiano Rosas wrote: >> From: Nikolay Borisov >> >> Implement the outgoing migration side for the 'fixed-ram' capability. >> >> A bitmap is introduced to track which pages have been written in the >> migration file. Pages are written

Re: [PATCH v2 15/29] migration/ram: Add support for 'fixed-ram' outgoing migration

2023-10-31 Thread Peter Xu
On Mon, Oct 23, 2023 at 05:35:54PM -0300, Fabiano Rosas wrote: > From: Nikolay Borisov > > Implement the outgoing migration side for the 'fixed-ram' capability. > > A bitmap is introduced to track which pages have been written in the > migration file. Pages are written at a fixed location for ev

Re: [PATCH v2 15/29] migration/ram: Add support for 'fixed-ram' outgoing migration

2023-10-25 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Mon, Oct 23, 2023 at 05:35:54PM -0300, Fabiano Rosas wrote: >> From: Nikolay Borisov >> >> Implement the outgoing migration side for the 'fixed-ram' capability. >> >> A bitmap is introduced to track which pages have been written in the >> migration file. Pages a

Re: [PATCH v2 15/29] migration/ram: Add support for 'fixed-ram' outgoing migration

2023-10-25 Thread Daniel P . Berrangé
On Mon, Oct 23, 2023 at 05:35:54PM -0300, Fabiano Rosas wrote: > From: Nikolay Borisov > > Implement the outgoing migration side for the 'fixed-ram' capability. > > A bitmap is introduced to track which pages have been written in the > migration file. Pages are written at a fixed location for ev

[PATCH v2 15/29] migration/ram: Add support for 'fixed-ram' outgoing migration

2023-10-23 Thread Fabiano Rosas
From: Nikolay Borisov Implement the outgoing migration side for the 'fixed-ram' capability. A bitmap is introduced to track which pages have been written in the migration file. Pages are written at a fixed location for every ramblock. Zero pages are ignored as they'd be zero in the destination m