Re: [PATCH v2 15/25] scripts/render-block-graph: switch to AQMP

2021-12-16 Thread John Snow
On Thu, Dec 16, 2021 at 5:58 AM Vladimir Sementsov-Ogievskiy < vsement...@virtuozzo.com> wrote: > 15.12.2021 22:39, John Snow wrote: > > Creating an instance of qemu.aqmp.ExecuteError is too involved here, so > > just drop the specificity down to a generic AQMPError. > > s/AQMPError/QMPError/ ? >

Re: [PATCH v2 15/25] scripts/render-block-graph: switch to AQMP

2021-12-16 Thread Beraldo Leal
On Wed, Dec 15, 2021 at 02:39:29PM -0500, John Snow wrote: > Creating an instance of qemu.aqmp.ExecuteError is too involved here, so > just drop the specificity down to a generic AQMPError. > > Signed-off-by: John Snow > --- > scripts/render_block_graph.py | 8 +++- > 1 file changed, 3 inser

Re: [PATCH v2 15/25] scripts/render-block-graph: switch to AQMP

2021-12-16 Thread Vladimir Sementsov-Ogievskiy
15.12.2021 22:39, John Snow wrote: Creating an instance of qemu.aqmp.ExecuteError is too involved here, so just drop the specificity down to a generic AQMPError. s/AQMPError/QMPError/ ? Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy --- scripts/render_block_grap

[PATCH v2 15/25] scripts/render-block-graph: switch to AQMP

2021-12-15 Thread John Snow
Creating an instance of qemu.aqmp.ExecuteError is too involved here, so just drop the specificity down to a generic AQMPError. Signed-off-by: John Snow --- scripts/render_block_graph.py | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/scripts/render_block_graph.py b/sc