Re: [PATCH v2 15/19] cutils: Set value in all qemu_strtosz* error paths

2023-05-19 Thread Hanna Czenczek
On 12.05.23 04:10, Eric Blake wrote: Making callers determine whether or not *value was populated on error is not nice for usability. Pre-patch, we have unit tests that check that *result is left unchanged on most EINVAL errors and set to 0 on many ERANGE errors. This is subtly different from l

[PATCH v2 15/19] cutils: Set value in all qemu_strtosz* error paths

2023-05-11 Thread Eric Blake
Making callers determine whether or not *value was populated on error is not nice for usability. Pre-patch, we have unit tests that check that *result is left unchanged on most EINVAL errors and set to 0 on many ERANGE errors. This is subtly different from libc strtoumax() behavior which returns