Re: [PATCH v2 13/22] qga: conditionalize schema for commands requiring fsfreeze

2024-07-12 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Thu, Jun 13, 2024 at 6:44 PM Daniel P. Berrangé wrote: > Rather than creating stubs for every command that just return > QERR_UNSUPPORTED, use 'if' conditions in the schema to fully > exclude generation of the filesystem freezing commands on POSIX > platforms

Re: [PATCH v2 13/22] qga: conditionalize schema for commands requiring fsfreeze

2024-07-03 Thread Philippe Mathieu-Daudé
On 13/6/24 17:43, Daniel P. Berrangé wrote: Rather than creating stubs for every command that just return QERR_UNSUPPORTED, use 'if' conditions in the schema to fully exclude generation of the filesystem freezing commands on POSIX platforms lacking the required APIs. The command will be rejected

[PATCH v2 13/22] qga: conditionalize schema for commands requiring fsfreeze

2024-06-13 Thread Daniel P . Berrangé
Rather than creating stubs for every command that just return QERR_UNSUPPORTED, use 'if' conditions in the schema to fully exclude generation of the filesystem freezing commands on POSIX platforms lacking the required APIs. The command will be rejected at QMP dispatch time instead, avoiding reimpl