Re: [PATCH v2 12/38] qapi/common.py: check with pylint

2020-09-23 Thread John Snow
On 9/23/20 12:18 PM, Cleber Rosa wrote: I still think we should record (and maybe I'm missing it) the pylint version used though. Anyway: Cover letter for all six parts mentions pylint 2.6.0! In the future this will be pinned in the CI mechanisms. --js

Re: [PATCH v2 12/38] qapi/common.py: check with pylint

2020-09-23 Thread Cleber Rosa
On Tue, Sep 22, 2020 at 05:00:35PM -0400, John Snow wrote: > Remove qapi/common.py from the pylintrc ignore list. > > Signed-off-by: John Snow $ pylint scripts/qapi/ --rcfile=scripts/qapi/pylintrc Your code has been r

Re: [PATCH v2 12/38] qapi/common.py: check with pylint

2020-09-22 Thread Eduardo Habkost
On Tue, Sep 22, 2020 at 05:00:35PM -0400, John Snow wrote: > Remove qapi/common.py from the pylintrc ignore list. > > Signed-off-by: John Snow No pylint warnings detected. Tested-by: Eduardo Habkost -- Eduardo

[PATCH v2 12/38] qapi/common.py: check with pylint

2020-09-22 Thread John Snow
Remove qapi/common.py from the pylintrc ignore list. Signed-off-by: John Snow --- scripts/qapi/pylintrc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc index 02dd22c863..6151427a51 100644 --- a/scripts/qapi/pylintrc +++ b/script