Re: [PATCH v2 12/13] s390x: protvirt: Disable address checks for PV guest IO emulation

2019-12-05 Thread Cornelia Huck
On Fri, 29 Nov 2019 04:48:08 -0500 Janosch Frank wrote: > IO instruction data is routed through SIDAD for protected guests, so > adresses do not need to be checked, as this is kernel memory. > > Signed-off-by: Janosch Frank > --- > target/s390x/ioinst.c | 26 +++--- > 1 fil

Re: [PATCH v2 12/13] s390x: protvirt: Disable address checks for PV guest IO emulation

2019-12-04 Thread Thomas Huth
On 29/11/2019 10.48, Janosch Frank wrote: > IO instruction data is routed through SIDAD for protected guests, so > adresses do not need to be checked, as this is kernel memory. > > Signed-off-by: Janosch Frank > --- > target/s390x/ioinst.c | 26 +++--- > 1 file changed, 19 in

Re: [PATCH v2 12/13] s390x: protvirt: Disable address checks for PV guest IO emulation

2019-11-29 Thread David Hildenbrand
On 29.11.19 10:48, Janosch Frank wrote: > IO instruction data is routed through SIDAD for protected guests, so > adresses do not need to be checked, as this is kernel memory. "do not need" - is it actually evil to check? I would have assumed the kernel checks and these checks are just superfluous

[PATCH v2 12/13] s390x: protvirt: Disable address checks for PV guest IO emulation

2019-11-29 Thread Janosch Frank
IO instruction data is routed through SIDAD for protected guests, so adresses do not need to be checked, as this is kernel memory. Signed-off-by: Janosch Frank --- target/s390x/ioinst.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/target/s390x/i