Re: [PATCH v2 11/42] accel/tcg: Perform aligned atomic reads in translator_ld

2025-03-31 Thread Philippe Mathieu-Daudé
Cc'ing Jim & Frank On 18/3/25 22:31, Richard Henderson wrote: Perform aligned atomic reads in translator_ld, if possible. According to https://lore.kernel.org/qemu-devel/20240607101403.1109-1-jim@sifive.com/ this is required for RISC-V Ziccif. Signed-off-by: Richard Henderson --- accel

Re: [PATCH v2 11/42] accel/tcg: Perform aligned atomic reads in translator_ld

2025-03-25 Thread Pierrick Bouvier
On 3/18/25 18:28, Richard Henderson wrote: On 3/18/25 17:15, Pierrick Bouvier wrote: @@ -329,7 +331,39 @@ static bool translator_ld(CPUArchState *env, DisasContextBase *db,   host = db->host_addr[1];   } -    memcpy(dest, host + (pc - base), len); + do_read: +    /* + * Assume

Re: [PATCH v2 11/42] accel/tcg: Perform aligned atomic reads in translator_ld

2025-03-19 Thread Pierrick Bouvier
On 3/18/25 14:31, Richard Henderson wrote: Perform aligned atomic reads in translator_ld, if possible. According to https://lore.kernel.org/qemu-devel/20240607101403.1109-1-jim@sifive.com/ this is required for RISC-V Ziccif. Signed-off-by: Richard Henderson --- accel/tcg/translator.c |

Re: [PATCH v2 11/42] accel/tcg: Perform aligned atomic reads in translator_ld

2025-03-18 Thread Richard Henderson
On 3/18/25 17:15, Pierrick Bouvier wrote: @@ -329,7 +331,39 @@ static bool translator_ld(CPUArchState *env, DisasContextBase *db,   host = db->host_addr[1];   } -    memcpy(dest, host + (pc - base), len); + do_read: +    /* + * Assume aligned reads should be atomic, if possible.

Re: [PATCH v2 11/42] accel/tcg: Perform aligned atomic reads in translator_ld

2025-03-18 Thread Pierrick Bouvier
On 3/18/25 14:31, Richard Henderson wrote: Perform aligned atomic reads in translator_ld, if possible. According to https://lore.kernel.org/qemu-devel/20240607101403.1109-1-jim@sifive.com/ this is required for RISC-V Ziccif. Signed-off-by: Richard Henderson --- accel/tcg/translator.c |

Re: [PATCH v2 11/42] accel/tcg: Perform aligned atomic reads in translator_ld

2025-03-18 Thread Alistair Francis
On Wed, Mar 19, 2025 at 7:36 AM Richard Henderson wrote: > > Perform aligned atomic reads in translator_ld, if possible. > According to > > https://lore.kernel.org/qemu-devel/20240607101403.1109-1-jim@sifive.com/ > > this is required for RISC-V Ziccif. Thanks Richard!! > > Signed-off-by: Ric

[PATCH v2 11/42] accel/tcg: Perform aligned atomic reads in translator_ld

2025-03-18 Thread Richard Henderson
Perform aligned atomic reads in translator_ld, if possible. According to https://lore.kernel.org/qemu-devel/20240607101403.1109-1-jim@sifive.com/ this is required for RISC-V Ziccif. Signed-off-by: Richard Henderson --- accel/tcg/translator.c | 42 ++