Re: [PATCH v2 11/13] audio: deprecate -soundhw pcspk

2020-05-21 Thread Paolo Bonzini
On 18/05/20 15:27, Gerd Hoffmann wrote: > Ah, cool, that shows that I'm on the right path with my idea ;) > Sneak preview: > https://git.kraxel.org/cgit/qemu/log/?h=sirius/soundhw > > Suggestions for a good name? I've used "pc.pcspk" for now, > but maybe "pc.audiodev0" or "pc.sound0" is bet

Re: [PATCH v2 11/13] audio: deprecate -soundhw pcspk

2020-05-18 Thread Gerd Hoffmann
Hi, > >> Initialization order looks tricky though. I'd have to create pcspk > >> early, simliar to flash, in pc_machine_initfn(). Problem is I don't > >> have a isa bus yet at that point (flash is sysbus and doesn't have this > >> problem). I'm open to suggestions hiow do deal with that best.

Re: [PATCH v2 11/13] audio: deprecate -soundhw pcspk

2020-05-18 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> Initialization order looks tricky though. I'd have to create pcspk >> early, simliar to flash, in pc_machine_initfn(). Problem is I don't >> have a isa bus yet at that point (flash is sysbus and doesn't have this >> problem). I'm open to suggestions hiow do d

Re: [PATCH v2 11/13] audio: deprecate -soundhw pcspk

2020-05-18 Thread Gerd Hoffmann
Hi, > Initialization order looks tricky though. I'd have to create pcspk > early, simliar to flash, in pc_machine_initfn(). Problem is I don't > have a isa bus yet at that point (flash is sysbus and doesn't have this > problem). I'm open to suggestions hiow do deal with that best. Seems I've

Re: [PATCH v2 11/13] audio: deprecate -soundhw pcspk

2020-05-18 Thread Gerd Hoffmann
On Mon, May 18, 2020 at 11:26:50AM +0100, Daniel P. Berrangé wrote: > On Mon, May 18, 2020 at 12:16:28PM +0200, Gerd Hoffmann wrote: > > On Fri, May 15, 2020 at 05:08:23PM +0200, Ján Tomko wrote: > > > On a Friday in 2020, Gerd Hoffmann wrote: > > > > Add deprecation message to the audio init fun

Re: [PATCH v2 11/13] audio: deprecate -soundhw pcspk

2020-05-18 Thread Ján Tomko
On a Monday in 2020, Daniel P. Berrangé wrote: On Mon, May 18, 2020 at 12:16:28PM +0200, Gerd Hoffmann wrote: On Fri, May 15, 2020 at 05:08:23PM +0200, Ján Tomko wrote: > On a Friday in 2020, Gerd Hoffmann wrote: > > Add deprecation message to the audio init function. > > > > Factor out audio in

Re: [PATCH v2 11/13] audio: deprecate -soundhw pcspk

2020-05-18 Thread Daniel P . Berrangé
On Mon, May 18, 2020 at 12:16:28PM +0200, Gerd Hoffmann wrote: > On Fri, May 15, 2020 at 05:08:23PM +0200, Ján Tomko wrote: > > On a Friday in 2020, Gerd Hoffmann wrote: > > > Add deprecation message to the audio init function. > > > > > > Factor out audio initialization and call that from > > > b

Re: [PATCH v2 11/13] audio: deprecate -soundhw pcspk

2020-05-18 Thread Gerd Hoffmann
On Fri, May 15, 2020 at 05:08:23PM +0200, Ján Tomko wrote: > On a Friday in 2020, Gerd Hoffmann wrote: > > Add deprecation message to the audio init function. > > > > Factor out audio initialization and call that from > > both audio init and realize, so setting audiodev via > > -global is enough

Re: [PATCH v2 11/13] audio: deprecate -soundhw pcspk

2020-05-15 Thread Ján Tomko
On a Friday in 2020, Gerd Hoffmann wrote: Add deprecation message to the audio init function. Factor out audio initialization and call that from both audio init and realize, so setting audiodev via -global is enough to properly initialize pcspk. Signed-off-by: Gerd Hoffmann --- hw/audio/pcspk.

[PATCH v2 11/13] audio: deprecate -soundhw pcspk

2020-05-15 Thread Gerd Hoffmann
Add deprecation message to the audio init function. Factor out audio initialization and call that from both audio init and realize, so setting audiodev via -global is enough to properly initialize pcspk. Signed-off-by: Gerd Hoffmann --- hw/audio/pcspk.c | 24 +--- 1 file cha