Re: [PATCH v2 10/38] qapi/common.py: delint with pylint

2020-09-24 Thread Cleber Rosa
On Wed, Sep 23, 2020 at 01:37:06PM -0400, John Snow wrote: > On 9/23/20 12:01 PM, Cleber Rosa wrote: > > On Tue, Sep 22, 2020 at 05:00:33PM -0400, John Snow wrote: > > > At this point, that just means using a consistent strategy for constant > > > names. > > > constants get UPPER_CASE and names no

Re: [PATCH v2 10/38] qapi/common.py: delint with pylint

2020-09-23 Thread John Snow
On 9/23/20 12:01 PM, Cleber Rosa wrote: On Tue, Sep 22, 2020 at 05:00:33PM -0400, John Snow wrote: At this point, that just means using a consistent strategy for constant names. constants get UPPER_CASE and names not used externally get a leading underscore. As a preference, while renaming cons

Re: [PATCH v2 10/38] qapi/common.py: delint with pylint

2020-09-23 Thread Cleber Rosa
On Tue, Sep 22, 2020 at 05:00:33PM -0400, John Snow wrote: > At this point, that just means using a consistent strategy for constant names. > constants get UPPER_CASE and names not used externally get a leading > underscore. > > As a preference, while renaming constants to be UPPERCASE, move them

Re: [PATCH v2 10/38] qapi/common.py: delint with pylint

2020-09-22 Thread Eduardo Habkost
On Tue, Sep 22, 2020 at 05:00:33PM -0400, John Snow wrote: > At this point, that just means using a consistent strategy for constant names. > constants get UPPER_CASE and names not used externally get a leading > underscore. > > As a preference, while renaming constants to be UPPERCASE, move them

[PATCH v2 10/38] qapi/common.py: delint with pylint

2020-09-22 Thread John Snow
At this point, that just means using a consistent strategy for constant names. constants get UPPER_CASE and names not used externally get a leading underscore. As a preference, while renaming constants to be UPPERCASE, move them to the head of the file. Generally, it's nice to be able to audit the