Re: [PATCH v2 10/10] accel/tcg: Encode breakpoint info into tb->cflags

2021-07-17 Thread Richard Henderson
On 7/17/21 10:58 AM, Peter Maydell wrote: +static uint32_t cflags_for_breakpoints(CPUState *cpu, target_ulong pc, + uint32_t cflags) +{ +uint32_t bflags = 0; + +if (unlikely(cpu->singlestep_enabled)) { +bflags = CF_BP_SSTEP; +} else { Wo

Re: [PATCH v2 10/10] accel/tcg: Encode breakpoint info into tb->cflags

2021-07-17 Thread Peter Maydell
On Mon, 12 Jul 2021 at 16:49, Richard Henderson wrote: > > Having this data in cflags means that hashing takes care > of selecting a TB with or without exceptions built in. > Which means that we no longer need to flush all TBs. > > This does require that we single-step while we're within a page >

[PATCH v2 10/10] accel/tcg: Encode breakpoint info into tb->cflags

2021-07-12 Thread Richard Henderson
Having this data in cflags means that hashing takes care of selecting a TB with or without exceptions built in. Which means that we no longer need to flush all TBs. This does require that we single-step while we're within a page that contains a breakpoint, so it's not yet ideal, but should be an i