Re: [PATCH v2 1/8] qapi/error: Repurpose QAPIError as a generic exception base class

2021-04-16 Thread John Snow
On 4/16/21 2:04 AM, Markus Armbruster wrote: John Snow writes: On 4/15/21 2:44 AM, Markus Armbruster wrote: John Snow writes: Rename QAPIError to QAPISourceError, and then create a new QAPIError class that serves as the basis for all of our other custom exceptions. Isn't the existing QAP

Re: [PATCH v2 1/8] qapi/error: Repurpose QAPIError as a generic exception base class

2021-04-15 Thread Markus Armbruster
John Snow writes: > On 4/15/21 2:44 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> Rename QAPIError to QAPISourceError, and then create a new QAPIError >>> class that serves as the basis for all of our other custom exceptions. >> >> Isn't the existing QAPIError such a base class alre

Re: [PATCH v2 1/8] qapi/error: Repurpose QAPIError as a generic exception base class

2021-04-15 Thread John Snow
On 4/15/21 2:44 AM, Markus Armbruster wrote: John Snow writes: Rename QAPIError to QAPISourceError, and then create a new QAPIError class that serves as the basis for all of our other custom exceptions. Isn't the existing QAPIError such a base class already? Peeking ahead... aha, your new

Re: [PATCH v2 1/8] qapi/error: Repurpose QAPIError as a generic exception base class

2021-04-14 Thread Markus Armbruster
John Snow writes: > Rename QAPIError to QAPISourceError, and then create a new QAPIError > class that serves as the basis for all of our other custom exceptions. Isn't the existing QAPIError such a base class already? Peeking ahead... aha, your new base class is abstract. Can you explain why

[PATCH v2 1/8] qapi/error: Repurpose QAPIError as a generic exception base class

2021-03-30 Thread John Snow
Rename QAPIError to QAPISourceError, and then create a new QAPIError class that serves as the basis for all of our other custom exceptions. Add docstrings to explain the intended function of each error class. Signed-off-by: John Snow --- docs/sphinx/qapidoc.py | 3 ++- scripts/qapi/error.py |