Re: [PATCH v2 1/6] hw/sd: sdhci: Don't transfer any data when command time out

2021-02-18 Thread Bin Meng
Hi Philippe, On Fri, Feb 19, 2021 at 12:25 AM Philippe Mathieu-Daudé wrote: > > On 2/16/21 4:46 AM, Bin Meng wrote: > > At the end of sdhci_send_command(), it starts a data transfer if the > > command register indicates data is associated. But the data transfer > > should only be initiated when t

Re: [PATCH v2 1/6] hw/sd: sdhci: Don't transfer any data when command time out

2021-02-18 Thread Philippe Mathieu-Daudé
On 2/18/21 5:25 PM, Philippe Mathieu-Daudé wrote: > On 2/16/21 4:46 AM, Bin Meng wrote: >> At the end of sdhci_send_command(), it starts a data transfer if the >> command register indicates data is associated. But the data transfer >> should only be initiated when the command execution has succeede

Re: [PATCH v2 1/6] hw/sd: sdhci: Don't transfer any data when command time out

2021-02-18 Thread Philippe Mathieu-Daudé
On 2/16/21 4:46 AM, Bin Meng wrote: > At the end of sdhci_send_command(), it starts a data transfer if the > command register indicates data is associated. But the data transfer > should only be initiated when the command execution has succeeded. > > With this fix, the following reproducer: > > o

[PATCH v2 1/6] hw/sd: sdhci: Don't transfer any data when command time out

2021-02-15 Thread Bin Meng
At the end of sdhci_send_command(), it starts a data transfer if the command register indicates data is associated. But the data transfer should only be initiated when the command execution has succeeded. With this fix, the following reproducer: outl 0xcf8 0x80001810 outl 0xcfc 0xe1068000 outl 0x