Re: [PATCH v2 1/4] nbd: Add multi-conn option

2025-05-27 Thread Markus Armbruster
Eric Blake writes: > On Tue, Apr 29, 2025 at 01:31:44PM +0200, Markus Armbruster wrote: >> > In the context of qemu that might suggest having separate >> > multi_conn_requested and multi_conn fields, where the latter can be >> > queried over QMP to find out what is actually going on. Could even

Re: [PATCH v2 1/4] nbd: Add multi-conn option

2025-05-27 Thread Eric Blake
On Tue, Apr 29, 2025 at 01:31:44PM +0200, Markus Armbruster wrote: > > In the context of qemu that might suggest having separate > > multi_conn_requested and multi_conn fields, where the latter can be > > queried over QMP to find out what is actually going on. Could even > > add multi_conn_max to

Re: [PATCH v2 1/4] nbd: Add multi-conn option

2025-05-23 Thread Eric Blake
On Fri, May 23, 2025 at 02:03:14PM +0300, Andrey Drobyshev wrote: > >> I agree with Markus that this setting value different from what's been > >> directly requested by user shouldn't go silent. Having some kind of > >> warning at the very least would be nice. > > > > Okay, I'll make sure to warn

Re: [PATCH v2 1/4] nbd: Add multi-conn option

2025-05-23 Thread Andrey Drobyshev
On 5/22/25 9:44 PM, Eric Blake wrote: > On Thu, May 22, 2025 at 08:38:34PM +0300, Andrey Drobyshev wrote: >> On 4/28/25 9:46 PM, Eric Blake wrote: >>> From: "Richard W.M. Jones" >>> >>> Add multi-conn option to the NBD client. This commit just adds the >>> option, it is not functional. >>> >>> Se

Re: [PATCH v2 1/4] nbd: Add multi-conn option

2025-05-22 Thread Eric Blake
On Thu, May 22, 2025 at 08:38:34PM +0300, Andrey Drobyshev wrote: > On 4/28/25 9:46 PM, Eric Blake wrote: > > From: "Richard W.M. Jones" > > > > Add multi-conn option to the NBD client. This commit just adds the > > option, it is not functional. > > > > Setting this to a value > 1 permits multi

Re: [PATCH v2 1/4] nbd: Add multi-conn option

2025-05-22 Thread Andrey Drobyshev
On 4/28/25 9:46 PM, Eric Blake wrote: > From: "Richard W.M. Jones" > > Add multi-conn option to the NBD client. This commit just adds the > option, it is not functional. > > Setting this to a value > 1 permits multiple connections to the NBD > server; a typical value might be 4. The default is

Re: [PATCH v2 1/4] nbd: Add multi-conn option

2025-04-29 Thread Markus Armbruster
"Richard W.M. Jones" writes: > On Tue, Apr 29, 2025 at 01:01:34PM +0200, Markus Armbruster wrote: >> "Richard W.M. Jones" writes: >> >> > On Tue, Apr 29, 2025 at 07:49:00AM +0200, Markus Armbruster wrote: >> >> Eric Blake writes: >> >> >> >> > From: "Richard W.M. Jones" >> >> > >> >> > Add m

Re: [PATCH v2 1/4] nbd: Add multi-conn option

2025-04-29 Thread Richard W.M. Jones
On Tue, Apr 29, 2025 at 01:01:34PM +0200, Markus Armbruster wrote: > "Richard W.M. Jones" writes: > > > On Tue, Apr 29, 2025 at 07:49:00AM +0200, Markus Armbruster wrote: > >> Eric Blake writes: > >> > >> > From: "Richard W.M. Jones" > >> > > >> > Add multi-conn option to the NBD client. This

Re: [PATCH v2 1/4] nbd: Add multi-conn option

2025-04-29 Thread Markus Armbruster
"Richard W.M. Jones" writes: > On Tue, Apr 29, 2025 at 07:49:00AM +0200, Markus Armbruster wrote: >> Eric Blake writes: >> >> > From: "Richard W.M. Jones" >> > >> > Add multi-conn option to the NBD client. This commit just adds the >> > option, it is not functional. >> > >> > Setting this to

Re: [PATCH v2 1/4] nbd: Add multi-conn option

2025-04-29 Thread Richard W.M. Jones
On Tue, Apr 29, 2025 at 07:49:00AM +0200, Markus Armbruster wrote: > Eric Blake writes: > > > From: "Richard W.M. Jones" > > > > Add multi-conn option to the NBD client. This commit just adds the > > option, it is not functional. > > > > Setting this to a value > 1 permits multiple connections

Re: [PATCH v2 1/4] nbd: Add multi-conn option

2025-04-28 Thread Markus Armbruster
Eric Blake writes: > From: "Richard W.M. Jones" > > Add multi-conn option to the NBD client. This commit just adds the > option, it is not functional. > > Setting this to a value > 1 permits multiple connections to the NBD > server; a typical value might be 4. The default is 1, meaning only a

[PATCH v2 1/4] nbd: Add multi-conn option

2025-04-28 Thread Eric Blake
From: "Richard W.M. Jones" Add multi-conn option to the NBD client. This commit just adds the option, it is not functional. Setting this to a value > 1 permits multiple connections to the NBD server; a typical value might be 4. The default is 1, meaning only a single connection is made. If th