Re: [PATCH v2 1/4] linux-user: Use `qemu_log' for non-strace logging

2020-02-03 Thread Josh Kunz
I've switched it to a LOG_UNIMP, similar to to the one several lines below. I will follow up with a change to switch this to an assert as recommended. On Tue, Jan 28, 2020 at 9:07 AM Laurent Vivier wrote: > > Le 28/01/2020 à 17:53, Alex Bennée a écrit : > > > > Laurent Vivier writes: > > > >> L

Re: [PATCH v2 1/4] linux-user: Use `qemu_log' for non-strace logging

2020-01-28 Thread Laurent Vivier
Le 28/01/2020 à 17:53, Alex Bennée a écrit : > > Laurent Vivier writes: > >> Le 17/01/2020 à 20:28, Josh Kunz a écrit : >>> Since most calls to `gemu_log` are actually logging unimplemented features, >>> this change replaces most non-strace calls to `gemu_log` with calls to >>> `qemu_log_mask(LO

Re: [PATCH v2 1/4] linux-user: Use `qemu_log' for non-strace logging

2020-01-28 Thread Alex Bennée
Laurent Vivier writes: > Le 17/01/2020 à 20:28, Josh Kunz a écrit : >> Since most calls to `gemu_log` are actually logging unimplemented features, >> this change replaces most non-strace calls to `gemu_log` with calls to >> `qemu_log_mask(LOG_UNIMP, ...)`. This allows the user to easily log to

Re: [PATCH v2 1/4] linux-user: Use `qemu_log' for non-strace logging

2020-01-28 Thread Laurent Vivier
Le 17/01/2020 à 20:28, Josh Kunz a écrit : > Since most calls to `gemu_log` are actually logging unimplemented features, > this change replaces most non-strace calls to `gemu_log` with calls to > `qemu_log_mask(LOG_UNIMP, ...)`. This allows the user to easily log to > a file, and to mask out these

[PATCH v2 1/4] linux-user: Use `qemu_log' for non-strace logging

2020-01-17 Thread Josh Kunz
Since most calls to `gemu_log` are actually logging unimplemented features, this change replaces most non-strace calls to `gemu_log` with calls to `qemu_log_mask(LOG_UNIMP, ...)`. This allows the user to easily log to a file, and to mask out these log messages if they desire. Note: This change is