Re: [PATCH v2 1/3] virtio: add ability to delete vq through a pointer

2019-12-09 Thread Pan Nengyuan
On 2019/12/10 0:58, Michael S. Tsirkin wrote: > On Mon, Dec 09, 2019 at 11:43:20AM -0500, Michael S. Tsirkin wrote: >> On Wed, Dec 04, 2019 at 03:31:54PM +0800, pannengy...@huawei.com wrote: >>> From: Pan Nengyuan >>> >>> Devices tend to maintain vq pointers, allow deleting them trough a vq >>

Re: [PATCH v2 1/3] virtio: add ability to delete vq through a pointer

2019-12-09 Thread Michael S. Tsirkin
On Mon, Dec 09, 2019 at 11:43:20AM -0500, Michael S. Tsirkin wrote: > On Wed, Dec 04, 2019 at 03:31:54PM +0800, pannengy...@huawei.com wrote: > > From: Pan Nengyuan > > > > Devices tend to maintain vq pointers, allow deleting them trough a vq > > pointer. > > You want to also mention something

Re: [PATCH v2 1/3] virtio: add ability to delete vq through a pointer

2019-12-09 Thread Michael S. Tsirkin
On Wed, Dec 04, 2019 at 03:31:54PM +0800, pannengy...@huawei.com wrote: > From: Pan Nengyuan > > Devices tend to maintain vq pointers, allow deleting them trough a vq pointer. You want to also mention something about clearing .used_elems to avoid chances of double free. > Signed-off-by: Michael

Re: [PATCH v2 1/3] virtio: add ability to delete vq through a pointer

2019-12-09 Thread Michael S. Tsirkin
On Wed, Dec 04, 2019 at 03:33:07AM -0500, Pankaj Gupta wrote: > > > From: Pan Nengyuan > > > > Devices tend to maintain vq pointers, allow deleting them trough a vq > > pointer. > > > > Signed-off-by: Michael S. Tsirkin > > Signed-off-by: Pan Nengyuan > > --- > > Changes v2 to v1: > > - add a

Re: [PATCH v2 1/3] virtio: add ability to delete vq through a pointer

2019-12-06 Thread Pan Nengyuan
On 2019/12/6 16:56, Amit Shah wrote: > On Fri, 2019-12-06 at 10:17 +0800, Pan Nengyuan wrote: >> On 2019/12/6 0:45, Amit Shah wrote: >>> On Wed, 2019-12-04 at 15:31 +0800, pannengy...@huawei.com wrote: From: Pan Nengyuan >>> >>> Shouldn't this be From: mst? >>> >>> I didn't find a ref to th

Re: [PATCH v2 1/3] virtio: add ability to delete vq through a pointer

2019-12-06 Thread Amit Shah
On Fri, 2019-12-06 at 10:17 +0800, Pan Nengyuan wrote: > On 2019/12/6 0:45, Amit Shah wrote: > > On Wed, 2019-12-04 at 15:31 +0800, pannengy...@huawei.com wrote: > > > From: Pan Nengyuan > > > > Shouldn't this be From: mst? > > > > I didn't find a ref to the original patch to confirm if you had

Re: [PATCH v2 1/3] virtio: add ability to delete vq through a pointer

2019-12-05 Thread Pan Nengyuan
On 2019/12/6 0:45, Amit Shah wrote: > On Wed, 2019-12-04 at 15:31 +0800, pannengy...@huawei.com wrote: >> From: Pan Nengyuan > > Shouldn't this be From: mst? > > I didn't find a ref to the original patch to confirm if you had to > adapt it in any way, though. > Here is the original patch:　ht

Re: [PATCH v2 1/3] virtio: add ability to delete vq through a pointer

2019-12-05 Thread Amit Shah
On Wed, 2019-12-04 at 15:31 +0800, pannengy...@huawei.com wrote: > From: Pan Nengyuan Shouldn't this be From: mst? I didn't find a ref to the original patch to confirm if you had to adapt it in any way, though. > Devices tend to maintain vq pointers, allow deleting them trough a vq > pointer. >

Re: [PATCH v2 1/3] virtio: add ability to delete vq through a pointer

2019-12-04 Thread Pankaj Gupta
> > On 2019/12/4 16:33, Pankaj Gupta wrote: > > > >> From: Pan Nengyuan > >> > >> Devices tend to maintain vq pointers, allow deleting them trough a vq > >> pointer. > >> > >> Signed-off-by: Michael S. Tsirkin > >> Signed-off-by: Pan Nengyuan > >> --- > >> Changes v2 to v1: > >> - add a new

Re: [PATCH v2 1/3] virtio: add ability to delete vq through a pointer

2019-12-04 Thread Pan Nengyuan
On 2019/12/4 22:40, Eric Blake wrote: > On 12/4/19 1:31 AM, pannengy...@huawei.com wrote: >> From: Pan Nengyuan >> >> Devices tend to maintain vq pointers, allow deleting them trough a vq >> pointer. > > through Thanks. I'm sorry for my carelessness. > >> >> Signed-off-by: Michael S. Tsirki

Re: [PATCH v2 1/3] virtio: add ability to delete vq through a pointer

2019-12-04 Thread Pan Nengyuan
On 2019/12/4 16:33, Pankaj Gupta wrote: > >> From: Pan Nengyuan >> >> Devices tend to maintain vq pointers, allow deleting them trough a vq >> pointer. >> >> Signed-off-by: Michael S. Tsirkin >> Signed-off-by: Pan Nengyuan >> --- >> Changes v2 to v1: >> - add a new function virtio_delete_que

Re: [PATCH v2 1/3] virtio: add ability to delete vq through a pointer

2019-12-04 Thread Eric Blake
On 12/4/19 1:31 AM, pannengy...@huawei.com wrote: From: Pan Nengyuan Devices tend to maintain vq pointers, allow deleting them trough a vq pointer. through Signed-off-by: Michael S. Tsirkin Signed-off-by: Pan Nengyuan --- Also, don't forget to send a 0/3 cover letter (any series longer

Re: [PATCH v2 1/3] virtio: add ability to delete vq through a pointer

2019-12-04 Thread Laurent Vivier
On 04/12/2019 08:31, pannengy...@huawei.com wrote: > From: Pan Nengyuan > > Devices tend to maintain vq pointers, allow deleting them trough a vq pointer. > > Signed-off-by: Michael S. Tsirkin > Signed-off-by: Pan Nengyuan > --- > Changes v2 to v1: > - add a new function virtio_delete_queue to

Re: [PATCH v2 1/3] virtio: add ability to delete vq through a pointer

2019-12-04 Thread Pankaj Gupta
> From: Pan Nengyuan > > Devices tend to maintain vq pointers, allow deleting them trough a vq > pointer. > > Signed-off-by: Michael S. Tsirkin > Signed-off-by: Pan Nengyuan > --- > Changes v2 to v1: > - add a new function virtio_delete_queue to cleanup vq through a vq pointer > --- > hw/vi

[PATCH v2 1/3] virtio: add ability to delete vq through a pointer

2019-12-03 Thread pannengyuan
From: Pan Nengyuan Devices tend to maintain vq pointers, allow deleting them trough a vq pointer. Signed-off-by: Michael S. Tsirkin Signed-off-by: Pan Nengyuan --- Changes v2 to v1: - add a new function virtio_delete_queue to cleanup vq through a vq pointer --- hw/virtio/virtio.c | 16