Re: [PATCH v2 1/3] util: validate whether O_DIRECT is supported after failure

2020-07-08 Thread Markus Armbruster
Daniel P. Berrangé writes: > Currently we suggest that a filesystem may not support O_DIRECT after > seeing an EINVAL. Other things can cause EINVAL though, so it is better > to do an explicit check, and then report a definitive error message. > > Signed-off-by: Daniel P. Berrangé > --- > util/

Re: [PATCH v2 1/3] util: validate whether O_DIRECT is supported after failure

2020-07-02 Thread Philippe Mathieu-Daudé
On 7/2/20 2:56 PM, Daniel P. Berrangé wrote: > Currently we suggest that a filesystem may not support O_DIRECT after > seeing an EINVAL. Other things can cause EINVAL though, so it is better > to do an explicit check, and then report a definitive error message. > > Signed-off-by: Daniel P. Berrang

[PATCH v2 1/3] util: validate whether O_DIRECT is supported after failure

2020-07-02 Thread Daniel P . Berrangé
Currently we suggest that a filesystem may not support O_DIRECT after seeing an EINVAL. Other things can cause EINVAL though, so it is better to do an explicit check, and then report a definitive error message. Signed-off-by: Daniel P. Berrangé --- util/osdep.c | 15 +++ 1 file chang