Re: [PATCH v2 1/3] stdvga: fix screen blanking

2024-06-05 Thread Marc-André Lureau
Hi On Wed, Jun 5, 2024 at 11:36 AM Gerd Hoffmann wrote: > > On Tue, Jun 04, 2024 at 10:27:18AM GMT, Marc-André Lureau wrote: > > Hi > > > > > +if (is_buffer_shared(surface)) { > > > > Perhaps the suggestion to rename the function (in the following patch) > > should instead be surface_is_alloc

Re: [PATCH v2 1/3] stdvga: fix screen blanking

2024-06-05 Thread Gerd Hoffmann
On Tue, Jun 04, 2024 at 10:27:18AM GMT, Marc-André Lureau wrote: > Hi > > > +if (is_buffer_shared(surface)) { > > Perhaps the suggestion to rename the function (in the following patch) > should instead be surface_is_allocated() ? that would match the actual > flag check. But callers would hav

Re: [PATCH v2 1/3] stdvga: fix screen blanking

2024-06-03 Thread Marc-André Lureau
Hi On Mon, Jun 3, 2024 at 7:18 PM Gerd Hoffmann wrote: > > In case the display surface uses a shared buffer (i.e. uses vga vram > directly instead of a shadow) go unshare the buffer before clearing it. > > This avoids vga memory corruption, which in turn fixes unblanking not > working properly wi

[PATCH v2 1/3] stdvga: fix screen blanking

2024-06-03 Thread Gerd Hoffmann
In case the display surface uses a shared buffer (i.e. uses vga vram directly instead of a shadow) go unshare the buffer before clearing it. This avoids vga memory corruption, which in turn fixes unblanking not working properly with X11. Cc: qemu-sta...@nongnu.org Resolves: https://gitlab.com/qem