Re: [PATCH v2 1/3] hw/net: Add npcm7xx emc model

2021-02-09 Thread Peter Maydell
On Tue, 9 Feb 2021 at 01:26, Doug Evans wrote: > On Mon, Feb 8, 2021 at 9:17 AM Peter Maydell wrote: >> Don't put local variable declarations in the middle of functions, >> please. Coding style says they should be at the start of a >> block (so, here, the start of the function). It looks like you

Re: [PATCH v2 1/3] hw/net: Add npcm7xx emc model

2021-02-08 Thread Doug Evans
On Mon, Feb 8, 2021 at 9:17 AM Peter Maydell wrote: > On Tue, 2 Feb 2021 at 23:29, Doug Evans wrote: > > > > This is a 10/100 ethernet device that has several features. > > Only the ones needed by the Linux driver have been implemented. > > See npcm7xx_emc.c for a list of unimplemented features.

Re: [PATCH v2 1/3] hw/net: Add npcm7xx emc model

2021-02-08 Thread Peter Maydell
On Tue, 2 Feb 2021 at 23:29, Doug Evans wrote: > > This is a 10/100 ethernet device that has several features. > Only the ones needed by the Linux driver have been implemented. > See npcm7xx_emc.c for a list of unimplemented features. > > Reviewed-by: Hao Wu > Reviewed-by: Avi Fishman > Signed-o

[PATCH v2 1/3] hw/net: Add npcm7xx emc model

2021-02-02 Thread dje--- via
This is a 10/100 ethernet device that has several features. Only the ones needed by the Linux driver have been implemented. See npcm7xx_emc.c for a list of unimplemented features. Reviewed-by: Hao Wu Reviewed-by: Avi Fishman Signed-off-by: Doug Evans --- hw/net/meson.build | 1 + h