Re: [PATCH v2 1/3] hw/block/pflash: Remove dynamic field width from trace events

2019-11-18 Thread Philippe Mathieu-Daudé
On 11/18/19 8:21 PM, Eric Blake wrote: On 11/14/19 3:26 PM, Philippe Mathieu-Daudé wrote: -    trace_pflash_data_read(offset, width << 1, ret); +    trace_pflash_data_read(offset, width << 3, ret); Umm, why is width changing?  That's not mentioned in the commit message. Previously it was us

Re: [PATCH v2 1/3] hw/block/pflash: Remove dynamic field width from trace events

2019-11-18 Thread Eric Blake
On 11/14/19 3:26 PM, Philippe Mathieu-Daudé wrote: -    trace_pflash_data_read(offset, width << 1, ret); +    trace_pflash_data_read(offset, width << 3, ret); Umm, why is width changing?  That's not mentioned in the commit message. Previously it was used to set the format width: [1, 2, 4] ->

Re: [PATCH v2 1/3] hw/block/pflash: Remove dynamic field width from trace events

2019-11-14 Thread Philippe Mathieu-Daudé
Hi Eric, On 11/8/19 4:56 PM, Eric Blake wrote: On 11/8/19 8:40 AM, Philippe Mathieu-Daudé wrote: Since not all trace backends support dynamic field width in format (dtrace via stap does not), replace by a static field width instead. Reported-by: Eric Blake Buglink: https://bugs.launchpad.net/

Re: [PATCH v2 1/3] hw/block/pflash: Remove dynamic field width from trace events

2019-11-08 Thread Eric Blake
On 11/8/19 8:40 AM, Philippe Mathieu-Daudé wrote: Since not all trace backends support dynamic field width in format (dtrace via stap does not), replace by a static field width instead. Reported-by: Eric Blake Buglink: https://bugs.launchpad.net/qemu/+bug/1844817 Signed-off-by: Philippe Mathieu

[PATCH v2 1/3] hw/block/pflash: Remove dynamic field width from trace events

2019-11-08 Thread Philippe Mathieu-Daudé
Since not all trace backends support dynamic field width in format (dtrace via stap does not), replace by a static field width instead. Reported-by: Eric Blake Buglink: https://bugs.launchpad.net/qemu/+bug/1844817 Signed-off-by: Philippe Mathieu-Daudé --- hw/block/pflash_cfi01.c | 8 h