Re: [PATCH v2 1/2] target/riscv: iterate over a table of decoders

2022-01-25 Thread Richard Henderson
On 1/14/22 7:20 AM, Philipp Tomsich wrote: +static inline bool always_true_p(CPURISCVState *env __attribute__((__unused__)), + DisasContext *ctx __attribute__((__unused__))) +{ +return true; +} Drop the inline; the function will be instantiated so that it

Re: [PATCH v2 1/2] target/riscv: iterate over a table of decoders

2022-01-20 Thread Philipp Tomsich
On Wed, 19 Jan 2022 at 12:30, Philippe Mathieu-Daudé wrote: > > On 13/1/22 21:20, Philipp Tomsich wrote: > > To split up the decoder into multiple functions (both to support > > vendor-specific opcodes in separate files and to simplify maintenance > > of orthogonal extensions), this changes decode

Re: [PATCH v2 1/2] target/riscv: iterate over a table of decoders

2022-01-19 Thread Philippe Mathieu-Daudé via
On 13/1/22 21:20, Philipp Tomsich wrote: To split up the decoder into multiple functions (both to support vendor-specific opcodes in separate files and to simplify maintenance of orthogonal extensions), this changes decode_op to iterate over a table of decoders predicated on guard functions. Thi

[PATCH v2 1/2] target/riscv: iterate over a table of decoders

2022-01-13 Thread Philipp Tomsich
To split up the decoder into multiple functions (both to support vendor-specific opcodes in separate files and to simplify maintenance of orthogonal extensions), this changes decode_op to iterate over a table of decoders predicated on guard functions. This commit only adds the new structure and th