On Wed, Feb 21, 2024 at 06:47:47PM +0500, Roman Khapov wrote:
> If I understood you right, you suggest to improve migrate_generate_event to
> accept MigrationState* instead of int* state (which is pointing to field
> MigrationState.state in all usages), and get error reason from
> MigrationState.er
The reason in MIGRATION event can be used, when there is some helpful
message, that can be added to improve debugging\understanding of the
reason of migration status changing.
I propose the next usage - when qemu sends (MIGRATION status=failed)
event, the error message describing the problem c
If I understood you right, you suggest to improve migrate_generate_event
to accept MigrationState* instead of int* state (which is pointing to
field MigrationState.state in all usages), and get error reason from
MigrationState.error, if the new state is MIGRATION_STATE_FAILED, is it?
That soun
On Thu, Feb 15, 2024 at 05:27:58PM +0500, Roman Khapov wrote:
> migrate_set_state(&mis->state, MIGRATION_STATUS_COLO,
> - MIGRATION_STATUS_COMPLETED);
> + MIGRATION_STATUS_COMPLETED, NULL);
Instead of enforcing migrate_set_error() to always pass an er
Roman Khapov writes:
> To be clear: you meant that the description of the event must be extended,
> similar to its description on the commit message? Or you don't see its proper
> usage at all?
The commit message doesn't really tell me either why and how anybody
would use @reason. Once we hav
To be clear: you meant that the description of the event must be
extended, similar to its description on the commit message? Or you don't
see its proper usage at all?
If the first is true, then I agree, the description can be improved, and
it will be useful, thanks! Will add it in the next ver
Roman Khapov writes:
> This commit adds the optional field reason for the events, which
> contains the string, describing reason of status changing.
> For example: reason of migration fail.
>
> Function migrate_set_state now accepts 4th argument: the reason to
> pass to event. Every call of this
This commit adds the optional field reason for the events, which
contains the string, describing reason of status changing.
For example: reason of migration fail.
Function migrate_set_state now accepts 4th argument: the reason to
pass to event. Every call of this function appended with NULL argume
