Re: [PATCH v2 1/2] migration: Fix iocs leaks during file and fd migration

2024-03-14 Thread Peter Xu
On Wed, Mar 13, 2024 at 06:28:23PM -0300, Fabiano Rosas wrote: > The memory for the io channels is being leaked in three different ways > during file migration: > > 1) if the offset check fails we never drop the ioc reference; > > 2) we allocate an extra channel for no reason; > > 3) if multifd

[PATCH v2 1/2] migration: Fix iocs leaks during file and fd migration

2024-03-13 Thread Fabiano Rosas
The memory for the io channels is being leaked in three different ways during file migration: 1) if the offset check fails we never drop the ioc reference; 2) we allocate an extra channel for no reason; 3) if multifd is enabled but channel creation fails when calling dup(), we leave the previ