Re: [PATCH v2 1/1] plugins: fix win plugin tests on cross compile

2023-11-09 Thread Greg Manning
> On 11/9/23 10:24, Greg Manning wrote: > >t += shared_module(i, files(i + '.c') + > > '../../contrib/plugins/win32_linker.c', > > include_directories: '../../include/qemu', > > -objects: [win32_qemu_plugin_api_lib], > > +

Re: [PATCH v2 1/1] plugins: fix win plugin tests on cross compile

2023-11-09 Thread Paolo Bonzini
On 11/9/23 10:24, Greg Manning wrote: t += shared_module(i, files(i + '.c') + '../../contrib/plugins/win32_linker.c', include_directories: '../../include/qemu', -objects: [win32_qemu_plugin_api_lib], +link_depends: [

[PATCH v2 1/1] plugins: fix win plugin tests on cross compile

2023-11-09 Thread Greg Manning
fixes #1927. Cross compile gcc is more picky about argument order than msys. Changed the meson command to take the (now renamed) libqemu_plugin_api.a as a lib, rather than an object. This puts it in the right place on both native and cross compile gcc commands Reenable plugins on crossbuilds Sig