Re: [PATCH v2 1/1] plugins: Move the windows linking function to qemu

2023-11-10 Thread Paolo Bonzini
On Fri, Nov 10, 2023 at 6:36 PM Greg Manning wrote: > Then hopefully when a plugin links to this, it gets the __pfnDliFailureHook2 > symbol defined and set up and everything would work. Except gcc strips > out any unreferenced symbols from static libs when linking. So the plugin > would have to be

Re: [PATCH v2 1/1] plugins: Move the windows linking function to qemu

2023-11-10 Thread Greg Manning
> Previously, a plugin author needed an implementation of the > __pfnDliFailureHook2 or __pfnDliNotifyHook2 hook in the plugin. Now all > they need is a null exported pointer with the right name (as in > win32_linker.c). If QEMU finds this, it will set it to the hook > function, which has now moved

Re: [PATCH v2 1/1] plugins: Move the windows linking function to qemu

2023-11-09 Thread Paolo Bonzini
On 11/9/23 10:25, Greg Manning wrote: Previously, a plugin author needed an implementation of the __pfnDliFailureHook2 or __pfnDliNotifyHook2 hook in the plugin. Now all they need is a null exported pointer with the right name (as in win32_linker.c). If QEMU finds this, it will set it to the hook

[PATCH v2 1/1] plugins: Move the windows linking function to qemu

2023-11-09 Thread Greg Manning
Previously, a plugin author needed an implementation of the __pfnDliFailureHook2 or __pfnDliNotifyHook2 hook in the plugin. Now all they need is a null exported pointer with the right name (as in win32_linker.c). If QEMU finds this, it will set it to the hook function, which has now moved into qemu