Re: [PATCH v2 1/1] Add vpd data for Rainier machine

2023-05-23 Thread Cédric Le Goater
On 5/23/23 23:48, Ninad Palsule wrote: Hello Philippe, On 5/23/23 3:52 AM, Philippe Mathieu-Daudé wrote: Hi Ninad, On 22/5/23 17:36, Ninad Palsule wrote: The VPD data is added for system and BMC FRU. This data is fabricated. Per https://www.qemu.org/docs/master/devel/submitting-a-patch.htm

Re: [PATCH v2 1/1] Add vpd data for Rainier machine

2023-05-23 Thread Ninad Palsule
Hello Philippe, On 5/23/23 3:52 AM, Philippe Mathieu-Daudé wrote: Hi Ninad, On 22/5/23 17:36, Ninad Palsule wrote: The VPD data is added for system and BMC FRU. This data is fabricated. Per https://www.qemu.org/docs/master/devel/submitting-a-patch.html#write-a-meaningful-commit-message:  

Re: [PATCH v2 1/1] Add vpd data for Rainier machine

2023-05-23 Thread Ninad Palsule
Hello Cedric, On 5/23/23 12:53 AM, Cédric Le Goater wrote: On 5/22/23 17:36, Ninad Palsule wrote: The VPD data is added for system and BMC FRU. This data is fabricated. Tested:     - The system-vpd.service is active.     - VPD service related to bmc is active. Signed-off-by: Ninad Palsule R

Re: [PATCH v2 1/1] Add vpd data for Rainier machine

2023-05-23 Thread Philippe Mathieu-Daudé
Hi Ninad, On 22/5/23 17:36, Ninad Palsule wrote: The VPD data is added for system and BMC FRU. This data is fabricated. Per https://www.qemu.org/docs/master/devel/submitting-a-patch.html#write-a-meaningful-commit-message: QEMU follows the usual standard for git commit messages: the first

Re: [PATCH v2 1/1] Add vpd data for Rainier machine

2023-05-22 Thread Cédric Le Goater
On 5/22/23 17:36, Ninad Palsule wrote: The VPD data is added for system and BMC FRU. This data is fabricated. Tested: - The system-vpd.service is active. - VPD service related to bmc is active. Signed-off-by: Ninad Palsule Reviewed-by: Cédric Le Goater Thanks, C. --- hw/arm/as

[PATCH v2 1/1] Add vpd data for Rainier machine

2023-05-22 Thread Ninad Palsule
The VPD data is added for system and BMC FRU. This data is fabricated. Tested: - The system-vpd.service is active. - VPD service related to bmc is active. Signed-off-by: Ninad Palsule --- hw/arm/aspeed.c| 6 -- hw/arm/aspeed_eeprom.c | 45 ++