Re: [PATCH v2 09/13] microvm: add minimal acpi support

2020-05-07 Thread Gerd Hoffmann
On Wed, May 06, 2020 at 04:14:19PM +0200, Igor Mammedov wrote: > On Wed, 6 May 2020 12:35:49 +0200 > Gerd Hoffmann wrote: > > > > > +/* FIXME: copy & paste */ > > > > +static void acpi_dsdt_add_power_button(Aml *scope) > > > > +{ > > > > +Aml *dev = aml_device(ACPI_POWER_BUTTON_DEVICE); > > >

Re: [PATCH v2 09/13] microvm: add minimal acpi support

2020-05-06 Thread Igor Mammedov
On Wed, 6 May 2020 12:35:49 +0200 Gerd Hoffmann wrote: > > > +/* FIXME: copy & paste */ > > > +static void acpi_dsdt_add_power_button(Aml *scope) > > > +{ > > > +Aml *dev = aml_device(ACPI_POWER_BUTTON_DEVICE); > > > +aml_append(dev, aml_name_decl("_HID", aml_string("PNP0C0C"))); > > > +

Re: [PATCH v2 09/13] microvm: add minimal acpi support

2020-05-06 Thread Gerd Hoffmann
> > +/* FIXME: copy & paste */ > > +static void acpi_dsdt_add_power_button(Aml *scope) > > +{ > > +Aml *dev = aml_device(ACPI_POWER_BUTTON_DEVICE); > > +aml_append(dev, aml_name_decl("_HID", aml_string("PNP0C0C"))); > > +aml_append(dev, aml_name_decl("_UID", aml_int(0))); > > +aml_a

Re: [PATCH v2 09/13] microvm: add minimal acpi support

2020-05-05 Thread Igor Mammedov
On Tue, 5 May 2020 15:43:01 +0200 Gerd Hoffmann wrote: > $subject says all. Can be disabled using the usual -no-acpi switch. > > Signed-off-by: Gerd Hoffmann > --- > hw/i386/acpi-microvm.h| 6 ++ > include/hw/i386/microvm.h | 8 ++ > hw/i386/acpi-microvm.c| 198 ++

[PATCH v2 09/13] microvm: add minimal acpi support

2020-05-05 Thread Gerd Hoffmann
$subject says all. Can be disabled using the usual -no-acpi switch. Signed-off-by: Gerd Hoffmann --- hw/i386/acpi-microvm.h| 6 ++ include/hw/i386/microvm.h | 8 ++ hw/i386/acpi-microvm.c| 198 ++ hw/i386/microvm.c | 22 + hw/i386/Kco