Re: [PATCH v2 09/12] qapi/meson: Restrict qdev code to system-mode emulation

2021-01-26 Thread Paolo Bonzini
On 24/01/21 01:32, Philippe Mathieu-Daudé wrote: The alternative is ugly: -- >8 -- diff --git a/hw/core/qdev.c b/hw/core/qdev.c index cefc5eaa0a9..d09f32e38d6 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -950,7 +950,9 @@ static void device_finalize(Object *obj) if (dev->pending_dele

Re: [PATCH v2 09/12] qapi/meson: Restrict qdev code to system-mode emulation

2021-01-23 Thread Philippe Mathieu-Daudé
On 1/23/21 7:10 PM, Paolo Bonzini wrote: > On 22/01/21 21:44, Philippe Mathieu-Daudé wrote: >> Beside a CPU device, user-mode emulation doesn't access >> anything else from qdev subsystem. >> >> Tools don't need anything from qdev. > > I prefer to avoid stubs.  So if this patch can simply be dropp

Re: [PATCH v2 09/12] qapi/meson: Restrict qdev code to system-mode emulation

2021-01-23 Thread Paolo Bonzini
On 22/01/21 21:44, Philippe Mathieu-Daudé wrote: Beside a CPU device, user-mode emulation doesn't access anything else from qdev subsystem. Tools don't need anything from qdev. I prefer to avoid stubs. So if this patch can simply be dropped with no effects on 10-12, that's nicer for me. Pa

[PATCH v2 09/12] qapi/meson: Restrict qdev code to system-mode emulation

2021-01-22 Thread Philippe Mathieu-Daudé
Beside a CPU device, user-mode emulation doesn't access anything else from qdev subsystem. Tools don't need anything from qdev. Signed-off-by: Philippe Mathieu-Daudé --- Cc: Laurent Vivier Cc: Eduardo Habkost --- stubs/qdev.c | 23 +++ MAINTAINERS | 1 + qapi/m