Re: [PATCH v2 09/12] acpi: move aml builder code for parallel device

2020-04-06 Thread Igor Mammedov
On Mon, 6 Apr 2020 12:26:52 +0200 Gerd Hoffmann wrote: > On Fri, Apr 03, 2020 at 12:16:01PM +0200, Igor Mammedov wrote: > > On Fri, 3 Apr 2020 12:12:10 +0200 > > Igor Mammedov wrote: > > > > > On Fri, 3 Apr 2020 10:04:59 +0200 > > > Gerd Hoffmann wrote: > > > > > [...] > > > > +static

Re: [PATCH v2 09/12] acpi: move aml builder code for parallel device

2020-04-06 Thread Paolo Bonzini
On 06/04/20 12:26, Gerd Hoffmann wrote: > -if (isa->iobase != 0x0378) { > +for (i = 0; i < ARRAY_SIZE(isa_parallel_io); i++) { > +if (isa->iobase == isa_parallel_io[i]) { > +uid = i + 1; > +} > +} > +if (!uid) { > return; > } > > @@ -583,8

Re: [PATCH v2 09/12] acpi: move aml builder code for parallel device

2020-04-06 Thread Gerd Hoffmann
On Fri, Apr 03, 2020 at 12:16:01PM +0200, Igor Mammedov wrote: > On Fri, 3 Apr 2020 12:12:10 +0200 > Igor Mammedov wrote: > > > On Fri, 3 Apr 2020 10:04:59 +0200 > > Gerd Hoffmann wrote: > > > [...] > > > +static void parallel_isa_build_aml(ISADevice *isadev, Aml *scope) > > > +{ > > > +IS

Re: [PATCH v2 09/12] acpi: move aml builder code for parallel device

2020-04-03 Thread Igor Mammedov
On Fri, 3 Apr 2020 12:12:10 +0200 Igor Mammedov wrote: > On Fri, 3 Apr 2020 10:04:59 +0200 > Gerd Hoffmann wrote: > [...] > > +static void parallel_isa_build_aml(ISADevice *isadev, Aml *scope) > > +{ > > +ISAParallelState *isa = ISA_PARALLEL(isadev); > > +Aml *dev; > > +Aml *crs; >

Re: [PATCH v2 09/12] acpi: move aml builder code for parallel device

2020-04-03 Thread Igor Mammedov
On Fri, 3 Apr 2020 10:04:59 +0200 Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > hw/char/parallel.c | 25 + > hw/i386/acpi-build.c | 23 --- > 2 files changed, 25 insertions(+), 23 deletions(-) > > diff --git a/hw/char/parallel.c b/hw

[PATCH v2 09/12] acpi: move aml builder code for parallel device

2020-04-03 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/char/parallel.c | 25 + hw/i386/acpi-build.c | 23 --- 2 files changed, 25 insertions(+), 23 deletions(-) diff --git a/hw/char/parallel.c b/hw/char/parallel.c index 8dd67d13759b..2bff1f17fda7 100644 --- a/hw/char/p