Re: [PATCH v2 09/11] tpm_tis_sysbus: move DSDT AML generation to device

2023-07-17 Thread Igor Mammedov
On Fri, 14 Jul 2023 10:29:31 -0700 Joelle van Dyne wrote: > On Fri, Jul 14, 2023 at 9:19 AM Stefan Berger wrote: > > > > > > > > > > I don't know whether we would want multiple devices. tpm_find() usage is > > certainly not prepared for multiple devices. > Sorry, "multiple TPM interfaces" her

Re: [PATCH v2 09/11] tpm_tis_sysbus: move DSDT AML generation to device

2023-07-14 Thread Joelle van Dyne
On Fri, Jul 14, 2023 at 11:01 AM Stefan Berger wrote: > > > > On 7/14/23 13:46, Joelle van Dyne wrote: > > On Fri, Jul 14, 2023 at 10:43 AM Stefan Berger > > wrote: > >> > >> > >> > >> On 7/14/23 13:39, Joelle van Dyne wrote: > >>> On Fri, Jul 14, 2023 at 10:37 AM Stefan Berger > >>> wrote: >

Re: [PATCH v2 09/11] tpm_tis_sysbus: move DSDT AML generation to device

2023-07-14 Thread Stefan Berger
On 7/14/23 13:46, Joelle van Dyne wrote: On Fri, Jul 14, 2023 at 10:43 AM Stefan Berger wrote: On 7/14/23 13:39, Joelle van Dyne wrote: On Fri, Jul 14, 2023 at 10:37 AM Stefan Berger wrote: On 7/14/23 13:29, Joelle van Dyne wrote: On Fri, Jul 14, 2023 at 9:19 AM Stefan Berger wrot

Re: [PATCH v2 09/11] tpm_tis_sysbus: move DSDT AML generation to device

2023-07-14 Thread Joelle van Dyne
On Fri, Jul 14, 2023 at 10:43 AM Stefan Berger wrote: > > > > On 7/14/23 13:39, Joelle van Dyne wrote: > > On Fri, Jul 14, 2023 at 10:37 AM Stefan Berger > > wrote: > >> > >> > >> > >> On 7/14/23 13:29, Joelle van Dyne wrote: > >>> On Fri, Jul 14, 2023 at 9:19 AM Stefan Berger > >>> wrote: > >

Re: [PATCH v2 09/11] tpm_tis_sysbus: move DSDT AML generation to device

2023-07-14 Thread Stefan Berger
On 7/14/23 13:39, Joelle van Dyne wrote: On Fri, Jul 14, 2023 at 10:37 AM Stefan Berger wrote: On 7/14/23 13:29, Joelle van Dyne wrote: On Fri, Jul 14, 2023 at 9:19 AM Stefan Berger wrote: I don't know whether we would want multiple devices. tpm_find() usage is certainly not prepa

Re: [PATCH v2 09/11] tpm_tis_sysbus: move DSDT AML generation to device

2023-07-14 Thread Joelle van Dyne
On Fri, Jul 14, 2023 at 10:37 AM Stefan Berger wrote: > > > > On 7/14/23 13:29, Joelle van Dyne wrote: > > On Fri, Jul 14, 2023 at 9:19 AM Stefan Berger wrote: > >> > >> > >> > >> > >> I don't know whether we would want multiple devices. tpm_find() usage is > >> certainly not prepared for multip

Re: [PATCH v2 09/11] tpm_tis_sysbus: move DSDT AML generation to device

2023-07-14 Thread Stefan Berger
On 7/14/23 13:29, Joelle van Dyne wrote: On Fri, Jul 14, 2023 at 9:19 AM Stefan Berger wrote: I don't know whether we would want multiple devices. tpm_find() usage is certainly not prepared for multiple devices. Sorry, "multiple TPM interfaces" here does not mean "at the same time". Wi

Re: [PATCH v2 09/11] tpm_tis_sysbus: move DSDT AML generation to device

2023-07-14 Thread Joelle van Dyne
On Fri, Jul 14, 2023 at 9:19 AM Stefan Berger wrote: > > > > > I don't know whether we would want multiple devices. tpm_find() usage is > certainly not prepared for multiple devices. Sorry, "multiple TPM interfaces" here does not mean "at the same time". Will clarify the description. > > > Good

Re: [PATCH v2 09/11] tpm_tis_sysbus: move DSDT AML generation to device

2023-07-14 Thread Stefan Berger
On 7/14/23 03:09, Joelle van Dyne wrote: This reduces redundent code in different machine types with ACPI table generation. Additionally, this will allow us to support multiple TPM interfaces. Finally, this matches up with the TPM TIS ISA I don't know whether we would want multiple devices.

[PATCH v2 09/11] tpm_tis_sysbus: move DSDT AML generation to device

2023-07-14 Thread Joelle van Dyne
This reduces redundent code in different machine types with ACPI table generation. Additionally, this will allow us to support multiple TPM interfaces. Finally, this matches up with the TPM TIS ISA implementation. Ideally, we would be able to call `qbus_build_aml` and avoid any TPM specific code i