Re: [PATCH v2 07/18] hw/ide/piix: Ensure IDE output IRQs are wired at realization

On Sun, Feb 19, 2023 at 10:54:34PM +0100, Philippe Mathieu-Daudé wrote: > +Daniel, Igor, Marcel & libvirt > > On 16/2/23 16:33, Philippe Mathieu-Daudé wrote: > > On 16/2/23 15:43, Bernhard Beschow wrote: > > > > > > > > > On Wed, Feb 15, 2023 at 5:20 PM Philippe Mathieu-Daudé > > > mailto:phi...

Re: [PATCH v2 07/18] hw/ide/piix: Ensure IDE output IRQs are wired at realization

On Mon, 20 Feb 2023, Bernhard Beschow wrote: IIUC, QEMU guarantees a deprecation period for at least two major versions. So if we deprecated user-creatable piix-ide in 8.1, we are not allowed to remove it before 10.1. Let's stick to our rules to give our users a chance to adapt gracefully. I

Re: [PATCH v2 07/18] hw/ide/piix: Ensure IDE output IRQs are wired at realization

Am 19. Februar 2023 21:54:34 UTC schrieb "Philippe Mathieu-Daudé" : >+Daniel, Igor, Marcel & libvirt > >On 16/2/23 16:33, Philippe Mathieu-Daudé wrote: >> On 16/2/23 15:43, Bernhard Beschow wrote: >>> >>> >>> On Wed, Feb 15, 2023 at 5:20 PM Philippe Mathieu-Daudé >>

Re: [PATCH v2 07/18] hw/ide/piix: Ensure IDE output IRQs are wired at realization

+Daniel, Igor, Marcel & libvirt On 16/2/23 16:33, Philippe Mathieu-Daudé wrote: On 16/2/23 15:43, Bernhard Beschow wrote: On Wed, Feb 15, 2023 at 5:20 PM Philippe Mathieu-Daudé mailto:phi...@linaro.org>> wrote:     Ensure both IDE output IRQ lines are wired.     We can remove the last use

Re: [PATCH v2 07/18] hw/ide/piix: Ensure IDE output IRQs are wired at realization

Am 16. Februar 2023 15:33:47 UTC schrieb "Philippe Mathieu-Daudé" : >On 16/2/23 15:43, Bernhard Beschow wrote: >> >> >> On Wed, Feb 15, 2023 at 5:20 PM Philippe Mathieu-Daudé > > wrote: >> >> Ensure both IDE output IRQ lines are wired. >> >> We can remove t

Re: [PATCH v2 07/18] hw/ide/piix: Ensure IDE output IRQs are wired at realization

On 16/2/23 15:43, Bernhard Beschow wrote: On Wed, Feb 15, 2023 at 5:20 PM Philippe Mathieu-Daudé mailto:phi...@linaro.org>> wrote: Ensure both IDE output IRQ lines are wired. We can remove the last use of isa_get_irq(NULL). Signed-off-by: Philippe Mathieu-Daudé mailto:phi...@li

Re: [PATCH v2 07/18] hw/ide/piix: Ensure IDE output IRQs are wired at realization

On Wed, Feb 15, 2023 at 5:20 PM Philippe Mathieu-Daudé wrote: > Ensure both IDE output IRQ lines are wired. > > We can remove the last use of isa_get_irq(NULL). > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/ide/piix.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-)

[PATCH v2 07/18] hw/ide/piix: Ensure IDE output IRQs are wired at realization

Ensure both IDE output IRQ lines are wired. We can remove the last use of isa_get_irq(NULL). Signed-off-by: Philippe Mathieu-Daudé --- hw/ide/piix.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/ide/piix.c b/hw/ide/piix.c index 9d876dd4a7..b75a4ddcca 10064