Re: [PATCH v2 07/12] virtio-gpu: Add virtio_gpu_resource_create_blob

2021-04-30 Thread Gerd Hoffmann
Hi, > [Kasireddy, Vivek] Right, we don't. I was also going to slightly change the > names of some > of the new functions in v3 to keep them consistent with the rest of the code. > Do you have > any additional feedback for the other patches that I can include in v3? Looks fine to me otherwise.

RE: [PATCH v2 07/12] virtio-gpu: Add virtio_gpu_resource_create_blob

2021-04-30 Thread Kasireddy, Vivek
Hi Gerd, > > res->remapsz = QEMU_ALIGN_UP(res->remapsz, > > qemu_real_host_page_size); > > > > res->remapped = mmap(NULL, res->remapsz, PROT_READ, @@ -152,7 > > +155,9 @@ void virtio_gpu_init_udmabuf(struct virtio_gpu_simple_resource > > *res) > > pdata = res->remapped; > >

Re: [PATCH v2 07/12] virtio-gpu: Add virtio_gpu_resource_create_blob

2021-04-28 Thread Gerd Hoffmann
Hi, > diff --git a/hw/display/virtio-gpu-udmabuf.c b/hw/display/virtio-gpu-udmabuf.c > index 2c0e7b2455..8bbce08550 100644 > --- a/hw/display/virtio-gpu-udmabuf.c > +++ b/hw/display/virtio-gpu-udmabuf.c > @@ -72,7 +72,10 @@ static void virtio_gpu_create_udmabuf(struct > virtio_gpu_simple_resour

[PATCH v2 07/12] virtio-gpu: Add virtio_gpu_resource_create_blob

2021-04-20 Thread Vivek Kasireddy
This API allows Qemu to register the blob allocated by the Guest as a new resource and map its backing storage. Based-on-patch-by: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- hw/display/trace-events | 1 + hw/display/virtio-gpu-udmabuf.c | 9 +++- hw/display/virtio-gpu.