I'm curious why there's two ranges as well.
In our branch of QEMU, I've had to modify this RTC creation code to have only
one range instead of two ranges.
Traditionally Macs have had one range for RTC and we have incompatibility with
a two ranges.
If you could change it to one range without lo
Hi,
> > > > > > +crs = aml_resource_template();
> > > > > > +aml_append(crs, aml_io(AML_DECODE16, 0x0070, 0x0070, 0x10,
> > > > > > 0x02));
> maybe replace magic 0x0070 with macro
> RTC_BASE_ADDR
Yes, that sounds better.
> > > > > > +aml_append(crs, aml_irq_no_flags(8));
> > > >
On Tue, 7 Apr 2020 12:26:58 +0200
Gerd Hoffmann wrote:
> On Mon, Apr 06, 2020 at 02:17:05PM +0200, Igor Mammedov wrote:
> > On Mon, 6 Apr 2020 10:25:17 +0200
> > Gerd Hoffmann wrote:
> >
> > > On Fri, Apr 03, 2020 at 12:09:21PM +0200, Igor Mammedov wrote:
> > > > On Fri, 3 Apr 2020 10:04:5
On Mon, Apr 06, 2020 at 02:17:05PM +0200, Igor Mammedov wrote:
> On Mon, 6 Apr 2020 10:25:17 +0200
> Gerd Hoffmann wrote:
>
> > On Fri, Apr 03, 2020 at 12:09:21PM +0200, Igor Mammedov wrote:
> > > On Fri, 3 Apr 2020 10:04:57 +0200
> > > Gerd Hoffmann wrote:
> > >
> > > > Signed-off-by: Gerd
On Mon, 6 Apr 2020 10:25:17 +0200
Gerd Hoffmann wrote:
> On Fri, Apr 03, 2020 at 12:09:21PM +0200, Igor Mammedov wrote:
> > On Fri, 3 Apr 2020 10:04:57 +0200
> > Gerd Hoffmann wrote:
> >
> > > Signed-off-by: Gerd Hoffmann
> > > ---
> > [...]
> > > +static void rtc_build_aml(ISADevice *i
On Fri, Apr 03, 2020 at 12:09:21PM +0200, Igor Mammedov wrote:
> On Fri, 3 Apr 2020 10:04:57 +0200
> Gerd Hoffmann wrote:
>
> > Signed-off-by: Gerd Hoffmann
> > ---
> [...]
> > +static void rtc_build_aml(ISADevice *isadev, Aml *scope)
> > +{
> > +Aml *dev;
> > +Aml *crs;
> > +
> > +
On Fri, 3 Apr 2020 10:04:57 +0200
Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
> ---
[...]
> +static void rtc_build_aml(ISADevice *isadev, Aml *scope)
> +{
> +Aml *dev;
> +Aml *crs;
> +
> +crs = aml_resource_template();
> +aml_append(crs, aml_io(AML_DECODE16, 0x0070, 0x00
Signed-off-by: Gerd Hoffmann
---
hw/i386/acpi-build.c | 17 -
hw/rtc/mc146818rtc.c | 20
2 files changed, 20 insertions(+), 17 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 77fc9df74735..a5bc7764e611 100644
--- a/hw/i386/acpi-bui
