Re: [PATCH v2 06/17] linux-user: Do not use guest_addr_valid for h2g_valid

2020-07-11 Thread Richard Henderson
On 7/11/20 12:30 PM, Richard Henderson wrote: >> The old implementation returns true for >> HOST_LONG_BITS <= TARGET_VIRT_ADDR_SPACE_BITS >> (because there's a different definition of guest_addr_valid() there) >> but this one does a range check even in that case. > > It's part and parcel with patc

Re: [PATCH v2 06/17] linux-user: Do not use guest_addr_valid for h2g_valid

2020-07-11 Thread Richard Henderson
On 6/25/20 9:34 AM, Peter Maydell wrote: > On Fri, 5 Jun 2020 at 05:17, Richard Henderson > wrote: >> >> This is the only use of guest_addr_valid that does not begin >> with a guest address, but a host address being transformed to >> a guest address. >> >> We will shortly adjust guest_addr_valid t

Re: [PATCH v2 06/17] linux-user: Do not use guest_addr_valid for h2g_valid

2020-06-25 Thread Peter Maydell
On Fri, 5 Jun 2020 at 05:17, Richard Henderson wrote: > > This is the only use of guest_addr_valid that does not begin > with a guest address, but a host address being transformed to > a guest address. > > We will shortly adjust guest_addr_valid to handle guest memory > tags, and the host address

[PATCH v2 06/17] linux-user: Do not use guest_addr_valid for h2g_valid

2020-06-04 Thread Richard Henderson
This is the only use of guest_addr_valid that does not begin with a guest address, but a host address being transformed to a guest address. We will shortly adjust guest_addr_valid to handle guest memory tags, and the host address should not be subjected to that. Move h2g_valid adjacent to the oth