Re: [PATCH v2 06/12] target/ppc: implement xscvspdpn with helper_todouble

2022-05-23 Thread Daniel Henrique Barboza
On 5/23/22 12:54, Richard Henderson wrote: On 5/23/22 06:48, Daniel Henrique Barboza wrote: Checking 0006-target-ppc-declare-xscvspdpn-helper-with-call-flags.patch... ERROR: spaces required around that '*' (ctx:WxV) #69: FILE: target/ppc/translate/vsx-impl.c.inc:1049: +bool trans_XSCVSPDPN(Di

Re: [PATCH v2 06/12] target/ppc: implement xscvspdpn with helper_todouble

2022-05-23 Thread Richard Henderson
On 5/23/22 06:48, Daniel Henrique Barboza wrote: Checking 0006-target-ppc-declare-xscvspdpn-helper-with-call-flags.patch... ERROR: spaces required around that '*' (ctx:WxV) #69: FILE: target/ppc/translate/vsx-impl.c.inc:1049: +bool trans_XSCVSPDPN(DisasContext *ctx, arg_XX2 *a)  

Re: [PATCH v2 06/12] target/ppc: implement xscvspdpn with helper_todouble

2022-05-23 Thread Daniel Henrique Barboza
./scripts/checkpatch.pl is complaining about something that I don't agree with: On 5/19/22 17:18, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Move xscvspdpn to decodetree, drop helper_xscvspdpn and use helper_todouble directly. Signed-off-by: Matheus Ferst --- target/ppc/fpu_

Re: [PATCH v2 06/12] target/ppc: implement xscvspdpn with helper_todouble

2022-05-20 Thread Richard Henderson
On 5/19/22 13:18, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Move xscvspdpn to decodetree, drop helper_xscvspdpn and use helper_todouble directly. Signed-off-by: Matheus Ferst --- target/ppc/fpu_helper.c | 5 - target/ppc/helper.h | 1 - targe

[PATCH v2 06/12] target/ppc: implement xscvspdpn with helper_todouble

2022-05-19 Thread matheus . ferst
From: Matheus Ferst Move xscvspdpn to decodetree, drop helper_xscvspdpn and use helper_todouble directly. Signed-off-by: Matheus Ferst --- target/ppc/fpu_helper.c | 5 - target/ppc/helper.h | 1 - target/ppc/insn32.decode| 1 + target/ppc/translat