Re: [PATCH v2 06/10] target/i386/kvm: rename architectural PMU variables

2025-03-09 Thread Dongli Zhang
On 3/7/25 1:19 AM, Zhao Liu wrote: >> +/* >> + * For Intel processors, the meaning is the architectural PMU version >> + * number. >> + * >> + * For AMD processors: 1 corresponds to the prior versions, and 2 >> + * corresponds to AMD PerfMonV2. >> + */ >> +static uint32_t has_pmu_version; > > T

Re: [PATCH v2 06/10] target/i386/kvm: rename architectural PMU variables

2025-03-07 Thread Zhao Liu
> +/* > + * For Intel processors, the meaning is the architectural PMU version > + * number. > + * > + * For AMD processors: 1 corresponds to the prior versions, and 2 > + * corresponds to AMD PerfMonV2. > + */ > +static uint32_t has_pmu_version; The "has_" prefix sounds like a boolean type. So wh

Re: [PATCH v2 06/10] target/i386/kvm: rename architectural PMU variables

2025-03-04 Thread Mi, Dapeng
On 3/3/2025 6:00 AM, Dongli Zhang wrote: > AMD does not have what is commonly referred to as an architectural PMU. > Therefore, we need to rename the following variables to be applicable for > both Intel and AMD: > > - has_architectural_pmu_version > - num_architectural_pmu_gp_counters > - num_ar

[PATCH v2 06/10] target/i386/kvm: rename architectural PMU variables

2025-03-02 Thread Dongli Zhang
AMD does not have what is commonly referred to as an architectural PMU. Therefore, we need to rename the following variables to be applicable for both Intel and AMD: - has_architectural_pmu_version - num_architectural_pmu_gp_counters - num_architectural_pmu_fixed_counters For Intel processors, th