Re: [PATCH v2 05/21] migration: Add Error** argument to qemu_savevm_state_setup()

2024-02-28 Thread Peter Xu
On Tue, Feb 27, 2024 at 07:03:29PM +0100, Cédric Le Goater wrote: > @@ -3469,9 +3479,15 @@ static void *bg_migration_thread(void *opaque) > > bql_lock(); > qemu_savevm_state_header(s->to_dst_file); > -qemu_savevm_state_setup(s->to_dst_file); > +ret = qemu_savevm_state_setup(s->t

[PATCH v2 05/21] migration: Add Error** argument to qemu_savevm_state_setup()

2024-02-27 Thread Cédric Le Goater
This prepares ground for the changes coming next which add an Error** argument to the .save_setup() handler. Callers of qemu_savevm_state_setup() now handle the error and fail earlier. This is a functional change that should be examined closely. Signed-off-by: Cédric Le Goater --- migration/save