Re: [PATCH v2 05/19] cutils: Fix wraparound parsing in qemu_strtoui

2023-05-19 Thread Eric Blake
On Fri, May 19, 2023 at 04:42:11PM +0200, Hanna Czenczek wrote: > On 12.05.23 04:10, Eric Blake wrote: > > While we were matching 32-bit strtol in qemu_strtoi, our use of a > > 64-bit parse was leaking through for some inaccurate answers in > > qemu_strtoui in comparison to a 32-bit strtoul. Fix t

Re: [PATCH v2 05/19] cutils: Fix wraparound parsing in qemu_strtoui

2023-05-19 Thread Hanna Czenczek
On 12.05.23 04:10, Eric Blake wrote: While we were matching 32-bit strtol in qemu_strtoi, our use of a 64-bit parse was leaking through for some inaccurate answers in qemu_strtoui in comparison to a 32-bit strtoul. Fix those, and update the testsuite now that our bounds checks are correct. Our

Re: [PATCH v2 05/19] cutils: Fix wraparound parsing in qemu_strtoui

2023-05-18 Thread Eric Blake
On Thu, May 11, 2023 at 09:10:19PM -0500, Eric Blake wrote: > > While we were matching 32-bit strtol in qemu_strtoi, our use of a > 64-bit parse was leaking through for some inaccurate answers in > qemu_strtoui in comparison to a 32-bit strtoul. Fix those, and update > the testsuite now that our

[PATCH v2 05/19] cutils: Fix wraparound parsing in qemu_strtoui

2023-05-11 Thread Eric Blake
While we were matching 32-bit strtol in qemu_strtoi, our use of a 64-bit parse was leaking through for some inaccurate answers in qemu_strtoui in comparison to a 32-bit strtoul. Fix those, and update the testsuite now that our bounds checks are correct. Our int wrappers would be a lot easier to w