Re: [PATCH v2 05/10] target/tricore: Fix RRPW_DEXTR

2023-02-02 Thread Richard Henderson
On 2/2/23 02:04, Bastian Koppelmann wrote: if we used const16 == 0 we would crash qemu with the error: ../tcg/tcg-op.c:196: tcg_gen_shri_i32: Assertion `arg2 >= 0 && arg2 < 32' failed This whole instruction can be handled by 'tcg_gen_extract2_tl' which takes care of this special case as well. S

[PATCH v2 05/10] target/tricore: Fix RRPW_DEXTR

2023-02-02 Thread Bastian Koppelmann
if we used const16 == 0 we would crash qemu with the error: ../tcg/tcg-op.c:196: tcg_gen_shri_i32: Assertion `arg2 >= 0 && arg2 < 32' failed This whole instruction can be handled by 'tcg_gen_extract2_tl' which takes care of this special case as well. Signed-off-by: Bastian Koppelmann --- v1 -> v