Re: [PATCH v2 04/18] monitor: Drop monitor_fdset_dup_fd_add()

2024-06-03 Thread Daniel P . Berrangé
Incorrect $SUBJECT - it claims to be removing monitor_fdset_dup_fd_add but actually removes monitor_fdset_dup_fd_find. On Thu, May 23, 2024 at 04:05:34PM -0300, Fabiano Rosas wrote: > From: Peter Xu > > This function is not needed, one remove function should already work. > Clean it up. > > Her

[PATCH v2 04/18] monitor: Drop monitor_fdset_dup_fd_add()

2024-05-23 Thread Fabiano Rosas
From: Peter Xu This function is not needed, one remove function should already work. Clean it up. Here the code doesn't really care about whether we need to keep that dupfd around if close() failed: when that happens something got very wrong, keeping the dup_fd around the fdsets may not help tha