Re: [PATCH v2 03/22] target/arm/hvf: Clean up local variable shadowing

2023-09-08 Thread Peter Maydell
On Mon, 4 Sept 2023 at 17:12, Philippe Mathieu-Daudé wrote: > > Per Peter Maydell analysis [*]: > > The hvf_vcpu_exec() function is not documented, but in practice > its caller expects it to return either EXCP_DEBUG (for "this was > a guest debug exception you need to deal with") or somethin

[PATCH v2 03/22] target/arm/hvf: Clean up local variable shadowing

2023-09-04 Thread Philippe Mathieu-Daudé
Per Peter Maydell analysis [*]: The hvf_vcpu_exec() function is not documented, but in practice its caller expects it to return either EXCP_DEBUG (for "this was a guest debug exception you need to deal with") or something else (presumably the intention being 0 for OK). The hvf_sysreg_re