Re: [PATCH v2 03/11] goldfish_rtc: Add endianness property

2022-07-04 Thread Jason A. Donenfeld
On Tue, Jul 05, 2022 at 05:40:31AM +0900, Stafford Horne wrote: > riscv{LE}--->goldfish_rtc{LE} > mips-longsoon3{LE}-->goldfish_rtc{LE} > openrisc{BE}>goldfish_rtc{LE} (LE to BE conversion done in > driver) > m68k{BE}>goldfish_rtc{BE} (only big-e

Re: [PATCH v2 03/11] goldfish_rtc: Add endianness property

2022-07-04 Thread Stafford Horne
On Mon, Jul 04, 2022 at 12:23:23PM +0200, Laurent Vivier wrote: > On 04/07/2022 12:21, Richard Henderson wrote: > > On 7/4/22 15:46, Laurent Vivier wrote: > > > On 04/07/2022 11:59, Richard Henderson wrote: > > > > On 7/4/22 02:58, Stafford Horne wrote: > > > > > -static const MemoryRegionOps goldf

Re: [PATCH v2 03/11] goldfish_rtc: Add endianness property

2022-07-04 Thread Stafford Horne
On Mon, Jul 04, 2022 at 03:29:57PM +0530, Richard Henderson wrote: > On 7/4/22 02:58, Stafford Horne wrote: > > -static const MemoryRegionOps goldfish_rtc_ops = { > > -.read = goldfish_rtc_read, > > -.write = goldfish_rtc_write, > > -.endianness = DEVICE_NATIVE_ENDIAN, > > -.valid =

Re: [PATCH v2 03/11] goldfish_rtc: Add endianness property

2022-07-04 Thread Laurent Vivier
On 04/07/2022 12:21, Richard Henderson wrote: On 7/4/22 15:46, Laurent Vivier wrote: On 04/07/2022 11:59, Richard Henderson wrote: On 7/4/22 02:58, Stafford Horne wrote: -static const MemoryRegionOps goldfish_rtc_ops = { -    .read = goldfish_rtc_read, -    .write = goldfish_rtc_write, -    .e

Re: [PATCH v2 03/11] goldfish_rtc: Add endianness property

2022-07-04 Thread Richard Henderson
On 7/4/22 15:46, Laurent Vivier wrote: On 04/07/2022 11:59, Richard Henderson wrote: On 7/4/22 02:58, Stafford Horne wrote: -static const MemoryRegionOps goldfish_rtc_ops = { -    .read = goldfish_rtc_read, -    .write = goldfish_rtc_write, -    .endianness = DEVICE_NATIVE_ENDIAN, -    .valid =

Re: [PATCH v2 03/11] goldfish_rtc: Add endianness property

2022-07-04 Thread Laurent Vivier
On 04/07/2022 11:59, Richard Henderson wrote: On 7/4/22 02:58, Stafford Horne wrote: -static const MemoryRegionOps goldfish_rtc_ops = { -    .read = goldfish_rtc_read, -    .write = goldfish_rtc_write, -    .endianness = DEVICE_NATIVE_ENDIAN, -    .valid = { -    .min_access_size = 4, - 

Re: [PATCH v2 03/11] goldfish_rtc: Add endianness property

2022-07-04 Thread Richard Henderson
On 7/4/22 02:58, Stafford Horne wrote: -static const MemoryRegionOps goldfish_rtc_ops = { -.read = goldfish_rtc_read, -.write = goldfish_rtc_write, -.endianness = DEVICE_NATIVE_ENDIAN, -.valid = { -.min_access_size = 4, -.max_access_size = 4 -} +static const Me

Re: [PATCH v2 03/11] goldfish_rtc: Add endianness property

2022-07-03 Thread Anup Patel
On Mon, Jul 4, 2022 at 2:59 AM Stafford Horne wrote: > > Add an endianness property to allow configuring the RTC as either > native, little or big endian. > > Cc: Laurent Vivier > Signed-off-by: Stafford Horne Looks good to me. Reviewed-by: Anup Patel Regards, Anup > --- > hw/rtc/goldfish_

[PATCH v2 03/11] goldfish_rtc: Add endianness property

2022-07-03 Thread Stafford Horne
Add an endianness property to allow configuring the RTC as either native, little or big endian. Cc: Laurent Vivier Signed-off-by: Stafford Horne --- hw/rtc/goldfish_rtc.c | 46 --- include/hw/rtc/goldfish_rtc.h | 2 ++ 2 files changed, 39 insertions(+),