Re: [PATCH v2 02/27] target/s390x: Use tcg_constant_* for DisasCompare

2022-12-11 Thread Philippe Mathieu-Daudé
On 11/12/22 16:27, Richard Henderson wrote: The a and b fields are not modified by the consumer, and while we need not free a constant, tcg will quietly ignore such frees, so free_compare need not be changed. Reviewed-by: Ilya Leoshkevich Signed-off-by: Richard Henderson --- target/s390x/tcg

[PATCH v2 02/27] target/s390x: Use tcg_constant_* for DisasCompare

2022-12-11 Thread Richard Henderson
The a and b fields are not modified by the consumer, and while we need not free a constant, tcg will quietly ignore such frees, so free_compare need not be changed. Reviewed-by: Ilya Leoshkevich Signed-off-by: Richard Henderson --- target/s390x/tcg/translate.c | 44 ++---