Re: [PATCH v2 02/16] qapi/expr.py: Check for dict instead of OrderedDict

2020-11-17 Thread John Snow
On 11/17/20 1:08 PM, Eduardo Habkost wrote: On Tue, Nov 17, 2020 at 05:30:04PM +0100, Markus Armbruster wrote: John Snow writes: OrderedDict is a subtype of dict, so we can check for a more general form. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa ---

Re: [PATCH v2 02/16] qapi/expr.py: Check for dict instead of OrderedDict

2020-11-17 Thread Eduardo Habkost
On Tue, Nov 17, 2020 at 05:30:04PM +0100, Markus Armbruster wrote: > John Snow writes: > > > OrderedDict is a subtype of dict, so we can check for a more general form. > > > > Signed-off-by: John Snow > > Reviewed-by: Eduardo Habkost > > Reviewed-by: Cleber Rosa > > --- > > scripts/qapi/expr.

Re: [PATCH v2 02/16] qapi/expr.py: Check for dict instead of OrderedDict

2020-11-17 Thread Markus Armbruster
John Snow writes: > OrderedDict is a subtype of dict, so we can check for a more general form. > > Signed-off-by: John Snow > Reviewed-by: Eduardo Habkost > Reviewed-by: Cleber Rosa > --- > scripts/qapi/expr.py | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/scri

[PATCH v2 02/16] qapi/expr.py: Check for dict instead of OrderedDict

2020-10-26 Thread John Snow
OrderedDict is a subtype of dict, so we can check for a more general form. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa --- scripts/qapi/expr.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.p