Re: [PATCH v2 01/13] hw/sd/sdhci: Set SDHC_NIS_DMA bit when appropriate

2025-01-16 Thread Michael Tokarev
17.01.2025 02:39, Bernhard Beschow wrote: Am 15. Januar 2025 12:55:29 UTC schrieb Michael Tokarev : Is this a qemu-stable material? Good question. Given that this part of the code has some further issues [1] I'd rather not alter stable behavior because we might just trade one bug for anoth

Re: [PATCH v2 01/13] hw/sd/sdhci: Set SDHC_NIS_DMA bit when appropriate

2025-01-16 Thread Bernhard Beschow
Am 15. Januar 2025 12:55:29 UTC schrieb Michael Tokarev : >11.01.2025 21:36, Bernhard Beschow wrote: >> In U-Boot, the fsl_esdhc[_imx] driver waits for both "transmit completed" and >> "DMA" bits in esdhc_send_cmd_common() by means of DATA_COMPLETE constant. >> QEMU >> currently misses to set t

Re: [PATCH v2 01/13] hw/sd/sdhci: Set SDHC_NIS_DMA bit when appropriate

2025-01-15 Thread Michael Tokarev
11.01.2025 21:36, Bernhard Beschow wrote: In U-Boot, the fsl_esdhc[_imx] driver waits for both "transmit completed" and "DMA" bits in esdhc_send_cmd_common() by means of DATA_COMPLETE constant. QEMU currently misses to set the DMA bit which causes the driver to loop forever. Fix that by setting t

[PATCH v2 01/13] hw/sd/sdhci: Set SDHC_NIS_DMA bit when appropriate

2025-01-11 Thread Bernhard Beschow
In U-Boot, the fsl_esdhc[_imx] driver waits for both "transmit completed" and "DMA" bits in esdhc_send_cmd_common() by means of DATA_COMPLETE constant. QEMU currently misses to set the DMA bit which causes the driver to loop forever. Fix that by setting the DMA bit if enabled when doing DMA block t