Re: [PATCH v2 01/10] target/ppc: Remove PowerPCCPUClass.handle_mmu_fault

2021-06-23 Thread David Gibson
On Mon, Jun 21, 2021 at 09:51:06AM -0300, Bruno Larsen (billionai) wrote: > From: Richard Henderson > > Instead, use a switch on env->mmu_model. This avoids some > replicated information in cpu setup. > > Signed-off-by: Richard Henderson As I mentioned on the earlier posting, I don't love the

Re: [PATCH v2 01/10] target/ppc: Remove PowerPCCPUClass.handle_mmu_fault

2021-06-22 Thread Greg Kurz
On Mon, 21 Jun 2021 09:51:06 -0300 "Bruno Larsen (billionai)" wrote: > From: Richard Henderson > > Instead, use a switch on env->mmu_model. This avoids some > replicated information in cpu setup. > > Signed-off-by: Richard Henderson > --- Very nice ! Reviewed-by: Greg Kurz > target/ppc/

[PATCH v2 01/10] target/ppc: Remove PowerPCCPUClass.handle_mmu_fault

2021-06-21 Thread Bruno Larsen (billionai)
From: Richard Henderson Instead, use a switch on env->mmu_model. This avoids some replicated information in cpu setup. Signed-off-by: Richard Henderson --- target/ppc/cpu-qom.h| 1 - target/ppc/cpu_init.c | 45 - target/ppc/mmu_helper.c | 24